Author Topic: Not all supported formats are shown in xmp-vgmstream  (Read 1328 times)

Sanxion7

  • Posts: 9
XMPlay will need to have a higher number of supported formats per plugin. xmp-vgmstream supports too many formats for XMPlay to show in the "supported filetypes" box.

Modern versions from this year as well as the one from 2021 on the XMPlay support site all have this issue with the latest XMPlay. The WinAmp plugin in that package even crashes XMPlay when you go to look at its plugin properties in "options and stuff".

The formats not shown from the list are also absent from the "Integration" tab.

Ian @ un4seen

  • Administrator
  • Posts: 25724
Indeed, XMPlay currently has a bug that will cause a crash if a plugin's filetypes list exceeds 1000 characters. Here's a fix for that:

   www.un4seen.com/stuff/xmplay.exe

In the case of xmp-vgmstream, I see it currently limits its filetypes list to 1000 characters due to this bug, so it will need an update to remove that workaround now with the XMPlay update/fix.

   https://github.com/vgmstream/vgmstream/blob/883d796d4b63c42810586e9f1ffbdcdd28c73ef5/xmplay/xmp_vgmstream.c#L33

andutrache

  • Posts: 12
Re: Not all supported formats are shown in xmp-vgmstream
« Reply #2 on: 14 Sep '23 - 01:11 »
This is pretty much the reason why I always stuck with the Winamp version of the plugin.
If the XMPlay plugin will be fixed by them I will use that instead.

Thanks to Ian fixing XMPlay I could finally update vgmstream, used to use v1745 which was the last one that worked, anything newer crashed XMPlay on trying to view the filetypes and on playing anything with the plugin.

Keltic Danor

  • XMPlay Support
  • Posts: 905
Re: Not all supported formats are shown in xmp-vgmstream
« Reply #3 on: 16 Sep '23 - 01:49 »
I let the vgmstream guys know and there is already an updated plugin available, I'm no expert but I gave it a try and it looks good to me. Don't forget to update your XMPlay to the latest stuff version first.

You can get it from the usual places:
https://support.xmplay.com/files_view.php?file_id=707
https://vgmstream.org/
https://github.com/vgmstream/vgmstream

andutrache

  • Posts: 12
Re: Not all supported formats are shown in xmp-vgmstream
« Reply #4 on: 17 Sep '23 - 10:25 »
Using the XMPlay plugin now and everything works as it should and all extensions are present.

Perfect, thanks a lot ;D

Ian @ un4seen

  • Administrator
  • Posts: 25724
Re: Not all supported formats are shown in xmp-vgmstream
« Reply #5 on: 18 Sep '23 - 12:52 »
Good to hear that it's working well now.

A little tip when a plugin has additional required DLLs (as in this case): because XMPlay sets the current directory to the plugin's directory before loading it, you should usually be able to put those additional DLLs alongside the plugin instead of XMPLAY.EXE, eg. you could keep all of the xmp-vgmstream files together in their own directory. That'll keep things a bit tidier and simpler to update.