Author Topic: SIDex plugin  (Read 4274 times)

Dhry

  • Posts: 127
Re: SIDex plugin
« Reply #125 on: 26 Oct '21 - 23:23 »
Nice work!

Also - what's in_ExorSid? Google doesn't turn anything up for that. Something else you wrote?

DRS

Malade

  • Posts: 60
Re: SIDex plugin
« Reply #126 on: 11 Nov '21 - 20:25 »
Hi ,
     Thank you, Exorsid is something i wrote a while back for when i wanted old sid to sound better with an extra 'something and ooo that sounds good , wow ...sound a bit different etc' ,
      its a sid remixer/player/betterer ,
      auto changes filters and chords etc so the music sounds different with a lot of other features too many to mention here,
      best to set it up before i start the engine or i will probably end up dying of old age once i start tinkering with the settings i'm there all day.

Dhry

  • Posts: 127
Re: SIDex plugin
« Reply #127 on: 12 Nov '21 - 19:37 »
Exorsid is something i wrote a while back for when i wanted old sid to sound better with an extra 'something and ooo that sounds good , wow ...sound a bit different etc' ,
its a sid remixer/player/betterer ,
auto changes filters and chords etc so the music sounds different with a lot of other features too many to mention here,
Sounds awesome, if it's in a releasable state I wouldn't mind checking it out, always fun to play around with the old chipmusic, add effects and whatnot.

Wanted to also check and see if you have the update SidEX ready as yet? Not that I'm chomping at the bit or anything.. 😁

DRS

Sebby75

  • Posts: 34
Re: SIDex plugin
« Reply #128 on: 28 Nov '21 - 10:54 »
Hi Malade,

Just a quick one.. are you still working on this? Are there any plans to release bug fixed version in the near future?
Christmas release?? Just in time for HVSC #76 ?  ;D ;) ;D :D
Obviously not pushing.. just asking.. I am busy as hell myself with daily life and work. Wish I could help but haven't written single line of code in almost 20 years.

Kind regards
Sebby75

Malade

  • Posts: 60
Re: SIDex plugin
« Reply #129 on: 6 Dec '21 - 22:47 »
Hi ,



see next post bug fixed

     completely forgot about this one apologies , seen the post added the latest  from libsidplayfp at the github and compiled it ( digi boost fix from drfiemost for 8580 ), minimal quick test and it runs , report any bugs thanks, no read me i am pushed for time again apologies , if you want to write one that would be great.

have fun :) , merry Christmas ( in advance ) and a happy new year to everyone , all the best  ;).



Regards ,
             Malade.

« Last Edit: 7 Dec '21 - 17:25 by Malade »

Malade

  • Posts: 60
Re: SIDex plugin
« Reply #130 on: 7 Dec '21 - 17:11 »
re download chaps , fixed a bug , attached to previous post ,latest sidex v2 rev x

Sebby75

  • Posts: 34
Re: SIDex plugin
« Reply #131 on: 7 Dec '21 - 17:21 »
Thanks Malade...

Downloaded 10 minutes ago and was going to report a bug (It was always defaulting to 6581 after opening and closing settings window)
::)  but I guess I will re-download and test again..

regards
Seb

Malade

  • Posts: 60
Re: SIDex plugin
« Reply #132 on: 7 Dec '21 - 17:23 »
re download chaps , fixed a bug , latest sidex v2 rev x
ok buddy , just to make sure , i removed the other download and attached it to this post, download this one , and report bugs please if you find any.

note: there is a bug somewhere in 8580 replay in libsidplayfp , something to do with filter and i think it is related to the digiboost , the sound is coming in a lot lower to the output buffer and the filters aren't applying properly at 48000 khz either , needs a bit of work , i will look into it if i remember and can find a bit of time to spare.

« Last Edit: 7 Dec '21 - 18:45 by Malade »

Malade

  • Posts: 60
Re: SIDex plugin
« Reply #133 on: 7 Dec '21 - 17:51 »
hi chaps ,
test this one please and get back to me , fixed part of the 8580 filter bug.

as usual , report any bugs you find and i will fix them when i can.

also test this tune please and see if it sounds normal to you.

/*Alexander Wiklund (Wiklund) - Cheese ( 2012 Onslaught )*/

oops my bad
Code: [Select]
    //filter8580->setFilterCurve(filterCurve);
filter8580->setFilterCurve(filterCurve + _8580_mod_filter[sid]); // << was this causing it something i was testing
« Last Edit: 7 Dec '21 - 18:45 by Malade »

Sebby75

  • Posts: 34
Re: SIDex plugin
« Reply #134 on: 7 Dec '21 - 17:58 »
Malade,

both first and second upload were called xmp-sidex__v2.0_rev1_.zip so i dont know how to refer to them...
xmp-sidex.dll inside zip file is 124848 bytes (crc32 c054ce78) modified 7/12/21 at 17:20


To me it sounds as if it was forcing 6581 for absolutely everything... it displays 8580 but plays as 6581.
Regardless of sid type chosen or whether lock is ticked or not it sounds identical (incorrect).
Tested with couple of fresh tunes from Transmission64 2021 Fall Edition

Version that you have uploaded earlier (crc32 03f7c34a) worked fine (detected 8580 and played correctly) but only until option window was opened and closed... from that point 6581 was being forced.

Not much free time for testing over the next 2 days.. will spend more time hammering it on Friday...

regards
Seb

Malade

  • Posts: 60
Re: SIDex plugin
« Reply #135 on: 7 Dec '21 - 18:36 »
correct and correct , it was something i was testing a while back and was still in the source , forgot all about it , did a bit of digging and found it.

Malade,

both first and second upload were called xmp-sidex__v2.0_rev1_.zip so i dont know how to refer to them...
xmp-sidex.dll inside zip file is 124848 bytes (crc32 c054ce78) modified 7/12/21 at 17:20


To me it sounds as if it was forcing 6581 for absolutely everything... it displays 8580 but plays as 6581.
Regardless of sid type chosen or whether lock is ticked or not it sounds identical (incorrect).
Tested with couple of fresh tunes from Transmission64 2021 Fall Edition

Version that you have uploaded earlier (crc32 03f7c34a) worked fine (detected 8580 and played correctly) but only until option window was opened and closed... from that point 6581 was being forced.

Not much free time for testing over the next 2 days.. will spend more time hammering it on Friday...

regards
Seb

ok buddy , my last upload fixes it all , should fix some of the fir issues as well from libsidplayfp , to be fair its based on a very old source which not many if any sound cards had > 44100 output , just needs a revision to 48000 output as it doesnt sound correct to me when outputting at 48000 ( ie accurate setting ) the firs sound wonky and ++ could be why the volumes dropping on the 8580 emulation or not maybe something else i will have to look into it.

rest should be fixed , get back to me with any bugs if you find them.
download attached file to this post to save any confusion
, cheers Malade.
« Last Edit: 7 Dec '21 - 18:49 by Malade »

Dhry

  • Posts: 127
Re: SIDex plugin
« Reply #136 on: 11 Dec '21 - 05:59 »
Apologies, have not been able to test lately, I threw out my back so can't sit in my regular chair at the PC, have to use the recliner in the lounge and a work laptop. Will see if I can spend some time with the new version next week.

Thanks for the hard work!
DRS

Dhry

  • Posts: 127
Re: SIDex plugin
« Reply #137 on: 11 Dec '21 - 17:54 »
I'm noticing that when you click OK in the options window, the window doesn't go away, and the next track in the playlist plays. Is this by design? (I mean the fact that OK does not dismiss options?)

DRS

Sebby75

  • Posts: 34
Re: SIDex plugin
« Reply #138 on: 11 Dec '21 - 19:18 »
I'm noticing that when you click OK in the options window, the window doesn't go away

Yeah.. this annoys me too and I can't see good reason for it to work that way.. due to limited free time earlier in the week i focused on pointing out just issues with incorrect playback on early 2.0  builds...  really wish we could just get that basic core functionality sorted before going mad with graphics equalisers and other bells and whistles.

regards
Sebby

Dhry

  • Posts: 127
Re: SIDex plugin
« Reply #139 on: 11 Dec '21 - 19:21 »
Yeah.. this annoys me too and I can't see good reason for it to work that way.. due to limited free time earlier in the week i focused on pointing out just issues with incorrect playback on early 2.0  builds...  really wish we could just get that basic core functionality sorted before going mad with graphics equalisers and other bells and whistles.

If KelticDanor hasn't already sent it to you, there's the option of using his version of the plugin as well. We're lucky enough to have a "deluxe" version as well as a regular one. Both appear to play back pretty well for me, but as they say - you can't make an omelet without breaking a few eggs and I'm personally willing to sit through some oddities and quirks to get something I know I'll use almost every day.

DRS

Sebby75

  • Posts: 34
Re: SIDex plugin
« Reply #140 on: 13 Dec '21 - 11:16 »
If KelticDanor hasn't already sent it to you, there's the option of using his version of the plugin as well.
DRS

@DRS
He did... and I am using it as my daily driver.

@Malade
Trying to test it some more now that I have bit more free time this week (YaY !! finally !!).

I am trying to uderstand how are "allow 2nd chip for 1sid" and "force 1sid difference" options supposed to work...
Is the idea that 1st chip is outputting only to left channel and 2nd chip to right channel? Or not??
I remember you had it on by default in past and it created slight offset between waveforms and bit of echoing (which drove me mad).
I'm trying to understand it's purpose and how it is supposed to work...
At the moment when I turn it on and say disable all voices of CHIP2 I can still hear sound in left and right channels (surround is off)
(but maybe this is how it is supposed to work).

Could do with bit of description of new options.. and how they are supposed to work.. instead of leaving it to us to guess and report bugs when something might be actually working as designed.

Not going to rant about OK button not closing option screen and jumping to next song (done too much ranting about that already)... at least it is now resetting song timer to 0:00 :)

Could do with option for automatic surround for multi sid tunes (2sid, 3sid, etc).  Don't know how about others but I always had it on when I used Fraggies plugin..
Probably doesn't matter that much when listening on speakers... but 2sid tunes on headphones are painfull without either surround or pan separation option.
On the other hand I don't like surround on single sid tunes, therefore I don't really want it on for everything.

Could do with song info displayed in options screen to be also shown in general info tab of xmplay.
Default sid type (and one currently playing if forced to be different), Player info.. etc.
It would make sense to make it easier to access...

libsidplayfp was recently updated to version 2.3.1


BUGS (will be adding on if i find any more):
  • When surround is switched on there seem to be a problem with some voices being silent when switching between single sid and multi sid tunes.
    (multi sid tune is missing some voices, i will test some more and give you examples to try)

    Stinsen - Space_Monkeys_2SID   (options used for playback are attached below)
    - played straight after opening xmplay - all sounds fine.   
    - and played again after another sid (single sid tune) - you can clearly hear that some voices are missing
    https://www.dropbox.com/sh/y8bofjascbhoo5l/AABqfGtQh2S8C1D583bz73Cwa?dl=0


  • When playing sid with subtunes, if you turn surround on or off and press OK, playback skips to next subtune which will play at double speed OR sometimes it will crash xmplay



Kindest regards
Sebby
« Last Edit: 13 Dec '21 - 14:26 by Sebby75 »

Malade

  • Posts: 60
Re: SIDex plugin
« Reply #141 on: 13 Dec '21 - 15:29 »
Hello lads ,

just got back , seen the posts and have just updated to latest libsidplayfp 2.3.1 2021-12-07, checking to see if i can repair what else is wrong , looking right now at this missing voice problem. ( fixed )

dialog staying open fixed.
tune playting at hyper speed ( gerbil wtf ) fixed
2 sid / 3 sid voices abandoning fixed.

force 1sid difference mutes 3 voices then reenables them to allow the fir filter to apply 10 micro seconds behind it i added this to get it sounding like it did back in 88 on an old amstrad stacker system in a brown cabinet , glass font , it had a surround button that i always listened to the music playing from the commodore breadbin on.

allow 2nd sid is to allow voice muting of left and right channels ( stereo but trying to keep the old mono and add slight buffers to the left right for pops and blows etc ) as i noticed libsidplay outputs on dual channels so i thought adding it would make it sound nice.

equaliser , well its an equaliser that changes different frequencies to make the sound of left and right mono slightly different ( its dual channel independent 20db) , i was going to add a 250 band eq but i don't know if the old laptops this could be used on would survive it so i blown it down to 10 x 2 .. 10 for left , 10 for right separately.

i will fix what i can and upload the new version soon. fixed reported problems , new version uploaded with libsidplay 2.3.1 and bug fixes.

btw i just made a playlist generator using sidid , it scans the whole hvsc or single files or folders and builds a m3u playlist with only the certain players , ie mon/ for jch player etc and i will add the timer files for anyone who has a 1541 ultimate II+ so you can play the songs with the right time instead of 5:00 on real hardware etc ( its good for tracking songs from a certain year which you remembered but forgot the name or where you heard it mainly crack intros with me tbh  ), when its finished il polish it up for you lot and release it , btw its dead simple to use , all drag and drop , dead easy peas'y.

right uploading latest version.

new version attached see below.

right laid back in my recliner playing mugsys revenge.

https://www.youtube.com/watch?v=738fJWztWaw

have fun and report any bugs if you find any.
« Last Edit: 13 Dec '21 - 16:39 by Malade »

Sebby75

  • Posts: 34
Re: SIDex plugin
« Reply #142 on: 13 Dec '21 - 18:14 »
Gave 2.6 quick 5 minute run...

right off the bat that tune I was testing with last time (Stinsen -Space Monkeys) sounds completely wrong... 3rd voice of 1st sid sounds completely different to what it should...
play that voice with sidplayfp.exe -u1 -u2 -u4 -u5 -u6 Space_Monkeys_2SID.sid  to hear what it should sound like

while tune is playing (and multiple tunes in the playlist)
go to options, press OK skips to next tune and plays 2nd sid with no sound at all...
when you go to options and press OK it skips to 3rd one and you can hear sound
and another OK is another skip and 4th sid plays with no sound at all...

that's me done for today :)

regards
Sebby

Malade

  • Posts: 60
Re: SIDex plugin
« Reply #143 on: 13 Dec '21 - 19:09 »
Hi sebby,
 thanks for letting me know buddy, il look into it for you when i can , i will tell you though that its playing ok here but i am a few versions above what i last posted , i will have a look into it though and see if i can replicate it.

btw the source is available if anyone would like to have a look or help.

Sebby75

  • Posts: 34
Re: SIDex plugin
« Reply #144 on: 13 Dec '21 - 19:41 »
Hi sebby,
 thanks for letting me know buddy, il look into it for you when i can , i will tell you though that its playing ok here but i am a few versions above what i last posted , i will have a look into it though and see if i can replicate it.

btw the source is available if anyone would like to have a look or help.

Malade.

Sources on github are 2 months old, could you update to current? Maybe then somebody can look at them and help.

Regards
Sebby



Malade

  • Posts: 60
Re: SIDex plugin
« Reply #145 on: 13 Dec '21 - 21:21 »
Hi sebby ,
               i have tried to update to git hub 3 or 4 times with no success, i get 'Failed to connect to github.com port 443: Timed out.' , no idea why.

 the latest version is attached, post back if you can with any bugs or suggestions btw the player core should be rock solid now i have changed the way the plugin inits the tunes and use xmplay stop and restart.

just tried again to update the github , same error , i may upload it here for now.

sourcecode attached.

bloody git hub  ::) , i will update trhe github when i can , meanwhile i have attached the source to this post. latest version 2.0 rev 2.7
« Last Edit: 13 Dec '21 - 21:58 by Malade »

Sebby75

  • Posts: 34
Re: SIDex plugin
« Reply #146 on: 13 Dec '21 - 21:58 »
I'm going back to same tune Stinsen - Space Monkeys.. have you even listened to it??

Listen to voice 3 of 1st SID... and only that voice...

plugin 2.5 (first run after opening xmplay) - voice 3 sounds correct

plugin 2.6 and 2.7 -- voice 3 sounds completely different

i mean it probably sounds wrong on most of the tunes but this is the one i picked to test earlier today and one that is pretty easy to hear the difference right at the start

https://www.dropbox.com/sh/pepu6o7wkez6n2m/AACYk-e0N6W9W125lQmmEZU3a?dl=0

http://deepsid.chordian.net/?file=/MUSICIANS/S/Stinsen/Space_Monkeys_2SID.sid



« Last Edit: 13 Dec '21 - 22:03 by Sebby75 »

Malade

  • Posts: 60
Re: SIDex plugin
« Reply #147 on: 13 Dec '21 - 21:59 »
I'm going back to same tune Stinsen - Space Monkeys.. have you even listened to it??

Listen to voice 3 of 1st SID... and only that voice...

plugin 2.5 (first run after opening xmplay) - voice 3 sounds correct

plugin 2.6 and 2.7 -- voice 3 sounds completely different

i mean it probably sounds wrong on most of the tunes but this is the one i picked to test earlier today and one that is pretty easy to hear the difference right at the start

https://www.dropbox.com/sh/pepu6o7wkez6n2m/AACYk-e0N6W9W125lQmmEZU3a?dl=0

http://deepsid.chordian.net/?file=/MUSICIANS/S/Stinsen/Space_Monkeys_2SID.sid

ive listened to it 5 times .. and both versions ( yes there is 2 versions ..)  and they sound correct to me.

https://deepsid.chordian.net/?file=Exotic%20SID%20Tunes%20Collection/Stereo%202SID/Stinsen/Space_Monkeys_2SID.sid

https://deepsid.chordian.net/?file=/MUSICIANS/S/Stinsen/Space_Monkeys_2SID.sid

ps your folders empty. https://www.dropbox.com/sh/pepu6o7wkez6n2m/AACYk-e0N6W9W125lQmmEZU3a?dl=0

Sebby75

  • Posts: 34
Re: SIDex plugin
« Reply #148 on: 13 Dec '21 - 22:06 »
files should be now in the dropbox folder...  named them earlier other way round by mistake...   only difference in setup is plugin version  2.5 vs 2.7

Malade

  • Posts: 60
Re: SIDex plugin
« Reply #149 on: 13 Dec '21 - 22:10 »
files should be now in the dropbox folder...  named them earlier other way round by mistake...   only difference in setup is plugin version  2.5 vs 2.7

ok buddy il have a listen now.