xmp-openmpt: An XMPlay input plugin based on OpenMPT

Started by saga, 31 Dec '13 - 17:10

saga

Together with the release of libopenmpt, we introduce the new OpenMPT input plugin for XMPlay, xmp-openmpt. Completely with its own pattern visualisation, it adds a great number of supported module formats to XMPlay and can also be used to replace XMPlay's own module renderer if you wish.

xmp-openmpt adds support for over 40 new module formats to XMPlay, including MPTM, STM, 667, 669, DSYM, MED, FAR, MDL, AMS, AMF, DSM, OKT, DMF, GTK, GT2, PTM, PSM, PSM16, MT2, DBM, DIGI, IMF, J2B, GDM, PLM, PT36, SFX, SYMMOD, ULT, MMS, DTM, STP, XMF and can also be used to replace XMPlay's existing MOD, XM, S3M, IT, MTM, MO3 and UMX support.

xmp-openmpt download
FAQ
report bugs

piovrauz

Oh, nice one. I can now replace some old plugins.
Btw, id this suppose to play modules with vst effects and stuff too?
Last question, the plugin config window doesn't show up here.
EDIT: Scrap that, it is shown, but behind the XMPlay config window, but it can't be selected (it blocks XMPlay config windows too).

saga

QuoteBtw, id this suppose to play modules with vst effects and stuff too?
No, plugins, DSP units and ITP files are the only features from OpenMPT not supported in libopenmpt.

Lunar07

Quote from: saga on 31 Dec '13 - 17:10Together with the release of libopenmpt, we introduce the new OpenMPT input plugin for XMPlay, xmp-openmpt. Completely with its own pattern visualisation, it adds a great number of supported module formats to XMPlay and can also be used to replace XMPlay's own module renderer if you wish.

xmp-openmpt download

Nice work but conflicting with the official MT2 plugin that supports reverb.
Please give us a file extension selector/deselector in configuration.

piovrauz

@ Lunar07: There's the XMPlay filetype priority do give priority to plugins (option and stuff, Input, priority filetypes).

@saga: ok. any Idea about the option window being behid and refussing moving?

Lunar07

It is not working and MT2 is going through the openmt plugin instead of its winamp plugin.
File extension selection/deselection is a MUST when a plugin supports a host of extensions.
Otherwise between this plugin and the video plugin we are going through a big mess of extensions.
Developers should not always count on "File Priority"

For example: AdPlug (for playing opl2/opl3 files) supports over 50 extensions.
It has a nice window to allow user to select and deselect.
So is AT2 plugin (another opl2/opl3 file player) that also supports ST3 and 10 more formats.

A tab in Configuration with "File Formats" to select and deselect is the way to go.
These are user enhancements that makes things orderly.

Quote from: piovrauz on 31 Dec '13 - 18:05@ Lunar07: There's the XMPlay filetype priority do give priority to plugins (option and stuff, Input, priority filetypes).

@saga: ok. any Idea about the option window being behid and refussing moving?


piovrauz

@saga: a clean xmplay doesn't solve that issue I reported, but I discovered it's triggered by the "always on top" setting (enabled for main windows). Hope it helps.
@Lunar07: too bad it doesn't work for you. I used it for another format and had no problem. You are right, for plugns with lots of formats it would be easier to have a config windows with the possibility to enable diasable support from within the plugin.

saga

QuoteSome Digitrakker MDLs aren't played:
The MDL loader needs to be completely rewritten anyway.

Anyway, there are no current plans to extend the plugin's functionality. Patches welcome. ;)

I'm not sure if there's any reason for not allowing the prioritised file extensions from Winamp plugins to override XMPlay plugins. Maybe Ian can shed some light on this.

Lunar07

Quote from: sagaI'm not sure if there's any reason for not allowing the prioritised file extensions from Winamp plugins to override XMPlay plugins. Maybe Ian can shed some light on this.


This is soon leading to a mess.
Including a config window to select and deselect file extensions is the way to go.
If there is anything Ian can do, and I say it jokingly, is to remove that Filetype Priority from xmplay.
Because it is making many developers just lazy.
OpenMPT is a very nice plugin. Make it nicer with including my suggestion.
You know, the originator of MPT used to listen to suggestions.  And I know him very well.
Whatever happens to the good old days when developers used to listen.

saga

QuoteYou know, the originator of MPT used to listen to suggestions.  And I know him very well.
You may not realize it but everyone involved with this project got a real life too. I wasn't involved in the making of the actual input plugin apart from rewriting the pattern visualisation. I (or anyone else involved with the project) will generally work on what I consider to be fun or useful. If that's not the same what you consider to be fun or useful, well then that's too bad. My main focus was and will be OpenMPT itself, not the input plugin. However, the great thing about open source is that you don't have to rely on a single person's current mood but can get involved on your own and add the functionality you want. That's why I'm working on OpenMPT, after all. And if you still think I don't listen to suggestions, go to the OpenMPT issue tracker and see the hundreds of suggestions and bugfixes I implemented over the years. Clearly if I was that selfish, I wouldn't have listened to so many people!

QuoteIf there is anything Ian can do, and I say it jokingly, is to remove that Filetype Priority from xmplay.
Because it is making many developers just lazy.
The last thing I need is being called lazy. Lazy would be to not have made this plugin reality. Why implement something a dozen times when it could be as simple as implementing it once, right in the core?

piovrauz

saga, about that bug, should I report it to openmodplug bugtracker?

saga

piovrauz: right now, neither of us has a clue why it's happening, so before it gets lost, you can do so, yeah.

piovrauz

Quote from: saga on 31 Dec '13 - 21:06piovrauz: right now, neither of us has a clue why it's happening, so before it gets lost, you can do so, yeah.

OK, done.

deus-ex

Quote from: piovrauz on 31 Dec '13 - 17:34Oh, nice one. I can now replace some old plugins.
Btw, id this suppose to play modules with vst effects and stuff too?
Last question, the plugin config window doesn't show up here.
EDIT: Scrap that, it is shown, but behind the XMPlay config window, but it can't be selected (it blocks XMPlay config windows too).
The file libopenmpt_settings.dll needs to be available in XMPlay's root folder, otherwise the plugin throws an error. Though any changes to the settings aren't saved permanently (at least this does not work for me).

piovrauz

@saga I see you tweaked my bug report. Since you added the foobar tag, I must say I can't see the config windows of the openMPT plugin at all: it decodes (DUMB removed) but can't find the settings...

@deus-ex: yup, I know that dll is needed, I read the readme (oh). I am fine with the default settings, so I didn't notice they weren't saved. :P

deus-ex

Quote from: piovrauz on 31 Dec '13 - 22:09@deus-ex: yup, I know that dll is needed, I read the readme (oh).

Funny you say that since there is no documentation included with the distribution. :)
Neither the download page nor the error message of the plugin hints that libopenmpt_settings.dll actually need to reside in the root folder of XMPlay/Winamp.

Happy New Year y'all!!!

piovrauz

@deus-ex: yes, there's no readme, and there's no mention that it should be the root directory, but there's mention in the DL page that for xmplay you need those 2 files.

Anyway:
1) if I have them in the root folder the bug I spotted still persist (sadly) EDIT: bug is solved by with build 0.2.3537 of the plugin! Never call those hardworking ppl on OpenMPT bugtracker lazy! XD
2) bug excluded, I get no errors watsoever, I can change the setting and they are persistent.

Ah, happy new year to you too.

Dotpitch

Quote from: Lunar07 on 31 Dec '13 - 18:21It is not working and MT2 is going through the openmt plugin instead of its winamp plugin.
Well, that shouldn't happen :). What did you put in the priority box? Could you upload the files so Ian can figure out why it's not passed to MT2?

saga et al, well done on the plugin!

piovrauz

I can confirm somthing is wrong with mt2.
I've installed the winamp plugin, got some .mt2 (full package of the tracker), put priority on the WA plugin, but it doesn't decode them.
OpenMPT plugin still gets to decode them (well, I hear silence when they play :P).
I would say it's something on the plugin side, or WA related, since it doesn't display config window too...

Dotpitch

Quote from: piovrauz on  1 Jan '14 - 11:08I've installed the winamp plugin, got some .mt2 (full package of the tracker), put priority on the WA plugin, but it doesn't decode them. ... I would say it's something on the plugin side, or WA related, since it doesn't display config window too...
Ah, that sounds similar to these issues with in_vgm. Ian, what's going on here?

manx_

Quote from: deus-ex on 31 Dec '13 - 22:06Though any changes to the settings aren't saved permanently (at least this does not work for me).

This should be fixed in r3538. Could you please check if http://buildbot.openmpt.org/builds/auto/libopenmpt-win32/libopenmpt-win32-r3538.7z works for you?

manx (libopenmpt developer)

piovrauz

manx_, can you please link that faq? or include it in the libOpenMPT archive? This thread has just the r3532 dl link. ;)
Saga can fix the thread, but if the docs were in the lib archive it would be easier for new users. Thanks.

saga

I've added a link to the FAQ in the first post, although all it requires is to just scroll down a bit on that page. ;)

piovrauz

Nice, you know, there are a lot of lazy ppls! XD
Anyway, I just noticed there's a link to most recent rev in that page too, I didn't see it first time.