Author Topic: Xmp-justlog plugin  (Read 3042 times)

Jace

  • Posts: 842
Re: Xmp-justlog plugin
« Reply #25 on: 22 Nov '21 - 17:34 »
Also getting the crash on untagged files while "excluded untitled" toggle is disabled

Keltic Danor

  • XMPlay Support
  • Posts: 881
Re: Xmp-justlog plugin
« Reply #26 on: 23 Nov '21 - 06:28 »
Hey!
This is a great plugin.
I would like to see more such features in your plugin:
1. Show track number.
2. Add the ability to line break. (Example:%2%line break%1).
Your plugin works great.
Maybe the new opportunities will be useful not only for me.
Thanks.
I think I can do that.

Also getting the crash on untagged files while "excluded untitled" toggle is disabled
Yeah... that'll teach me to just pop in a change and not actually test it I suppose.

Important Note for this update!
Due to a config change this version is not compatible with settings from the older versions, I know its annoying but I've been putting it off for a while.

  • Copy your string format settings to notepad
  • Remove the old Just Log from your plugin list
  • Close xmplay
  • Copy over the new plugin
  • Copy back your settings as needed

-snip-
« Last Edit: 10 Feb '22 - 17:09 by Keltic Danor »

100m0t0log

  • Posts: 6
Re: Xmp-justlog plugin
« Reply #27 on: 23 Nov '21 - 09:11 »
Bravo!!!
With my settings, it works as I wanted.
Thank you very much!!!

100m0t0log

  • Posts: 6
Re: Xmp-justlog plugin
« Reply #28 on: 23 Nov '21 - 09:31 »
Sorry for my immodesty.
Is it possible to implement in your plugin:
1. Display of the number of tracks in the playlist.
2. Displays the activation of the "Random play order" button. (For example, the letter "R" if enabled, no letter if disabled.)
3. Displays the inclusion of button "Loop list". (For example, letter "L" if enabled, no letter if disabled.
If it's difficult, then don't bother. Version 1.8 is a great option for mine.

Keltic Danor

  • XMPlay Support
  • Posts: 881
Re: Xmp-justlog plugin
« Reply #29 on: 23 Nov '21 - 15:10 »
Sorry for my immodesty.
Is it possible to implement in your plugin:
1. Display of the number of tracks in the playlist.
2. Displays the activation of the "Random play order" button. (For example, the letter "R" if enabled, no letter if disabled.)
3. Displays the inclusion of button "Loop list". (For example, letter "L" if enabled, no letter if disabled.
If it's difficult, then don't bother. Version 1.8 is a great option for mine.
I'm not quite sure how to get those settings but yes it is probably more difficult than it is worth. 8)

I've updated it to 1.8 with another fix to the exclude untitled setting not following the option correctly.
« Last Edit: 24 Nov '21 - 05:41 by Keltic Danor »

piovrauz

  • Posts: 1006
Re: Xmp-justlog plugin
« Reply #30 on: 23 Nov '21 - 17:57 »
ehm, I just updated from v 1.5 something and now I get this on play...

any idea what's happening?

« Last Edit: 23 Nov '21 - 18:03 by piovrauz »

sveakul

  • Posts: 144
Re: Xmp-justlog plugin
« Reply #31 on: 23 Nov '21 - 22:34 »
The problems are:

1.  You have "%8" in the Exclude Types box, instead of the file extensions themselves as shown in the example by the box (MP3,FLAC). 

2.  You have code in the "Max Size" box instead of a number (note the "KB" label next to it?)

3.  Depending what extensions you put in the Exclude Types box, you have ALL the "exclude" boxes underneath checked, which means nothing will be logged at all from whatever extensions specified, so be careful about the choices made there.

Keltic Danor

  • XMPlay Support
  • Posts: 881
Re: Xmp-justlog plugin
« Reply #32 on: 23 Nov '21 - 23:34 »
Read the big red text mate.  ;D ;D

V1.8+ needs you to remove the old first and redo the settings.

Edit: Updated to 1.8.2, no significant change besides correcting the version numbers.
« Last Edit: 24 Nov '21 - 05:41 by Keltic Danor »

100m0t0log

  • Posts: 6
Re: Xmp-justlog plugin
« Reply #33 on: 24 Nov '21 - 06:30 »
I'm not quite sure how to get those settings but yes it is probably more difficult than it is worth. 8)
Thanks for your work.

Jo Li KMC

  • Posts: 26
Re: Xmp-justlog plugin
« Reply #34 on: 25 Nov '21 - 10:12 »
Ya know something?  v1.8.2 has pretty much all the functionality I'd like, in the exact ways I'd like it~

I know that sounds selfish, and I'll be honest: it kind of is?  But the fact that you went and implemented it makes me really happy!  You totally didn't have to, and you didn't even have to fix the errors or anything, but you're being patient, and diligent, and just plain awesome!

Once more, from the bottom of my heart, thank you for going to all this trouble to make this plugin the best of its kind, Keltic Danor!  You're one of the good ones~!
(And it's even more impressive, considering you wrote the original version in, like, less than a week with little-to-no experience!)

piovrauz

  • Posts: 1006
Re: Xmp-justlog plugin
« Reply #35 on: 27 Nov '21 - 18:00 »
well, did read the red text, and did the stuff right on the xmplay I keep on usb as portable mousic source... but totally forgot for the home box... oopsie :P

piovrauz

  • Posts: 1006
Re: Xmp-justlog plugin
« Reply #36 on: 4 Dec '21 - 20:31 »
Something strange is happening...

I did like the _big red text said_ on my main setup but now xmplay crashes as soon I try to load justlog...

Any idea? If possible I'd like to not have to start from scratch :P

Keltic Danor

  • XMPlay Support
  • Posts: 881
Re: Xmp-justlog plugin
« Reply #37 on: 5 Dec '21 - 00:58 »
Something strange is happening...

I did like the _big red text said_ on my main setup but now xmplay crashes as soon I try to load justlog...

Any idea? If possible I'd like to not have to start from scratch :P
If you pop the old one back in it should load your settings fine for you to copy.

After you get the settings you can try just deleting the plugin and starting xmplay, it should remove the settings so you can upgrade.

piovrauz

  • Posts: 1006
Re: Xmp-justlog plugin
« Reply #38 on: 5 Dec '21 - 09:24 »
I meant just that:

- I closed xmplay, deleted justlog, launched xmplay, closed xmplay
- I added justlog, launched xmplay
- I tried to add justlog to the "DSP and general plugins", but as soon I hit the "add" buttono xmplay crashes.

But I discovered that deleting the log file fixes the crash! then I can add justlog again, change setting and readd the logfile. Yesss.

(the logfile was outside xmplay folder, on D:\, the second disk) - maybe something about that was the cause?

Keltic Danor

  • XMPlay Support
  • Posts: 881
Re: Xmp-justlog plugin
« Reply #39 on: 5 Dec '21 - 16:24 »
I meant just that:

- I closed xmplay, deleted justlog, launched xmplay, closed xmplay
- I added justlog, launched xmplay
- I tried to add justlog to the "DSP and general plugins", but as soon I hit the "add" buttono xmplay crashes.

But I discovered that deleting the log file fixes the crash! then I can add justlog again, change setting and readd the logfile. Yesss.

(the logfile was outside xmplay folder, on D:\, the second disk) - maybe something about that was the cause?
Ooh, maybe yes.

I really should put in some error handling instead of dishing out explosions left and right. I imagine it had a problem accessing it for some reason.

piovrauz

  • Posts: 1006
Re: Xmp-justlog plugin
« Reply #40 on: 5 Feb '22 - 16:04 »
strange enough, on a clean "install" xmplay (usb drive) justlog doesn't show up anymore... system is window10, kind of puzzled since the old key used to work fine (I didn't copy xmplay folder, just regot the stuff I needed)

saga

  • Posts: 2615
Re: Xmp-justlog plugin
« Reply #41 on: 5 Feb '22 - 16:18 »
Different plugins may use different runtime versions. What exactly is missing can be found out by using Dependency Walker (or better this modern replacement) and loading the DLL file into it. In this particular case, it will tell you that xmp-justlog.dll depends on msvcr100.dll and msvcp100.dll, which are part of the Visual C++ 2010 runtime. You can download it here: https://download.microsoft.com/download/5/B/C/5BC5DBB3-652D-4DCE-B14A-475AB85EEF6E/vcredist_x86.exe

tbrg-22

  • Posts: 3
Re: Xmp-justlog plugin
« Reply #42 on: 10 Feb '22 - 00:29 »
Plugin did not work for me either.. I never had it installed before, because I only discovered XMPlay last month! o)

I tried installing vcredist_x86.exe, but it said, I already had a newer version, so it would not install.

XMPlay will also just stop playing when trying to add the plugin with the "Add" button, nothing else happens and XMPlay process won't quit anymore, needs task manager to kill it. Do you have any other ideas how to get this plugin working?

Keltic Danor

  • XMPlay Support
  • Posts: 881
Re: Xmp-justlog plugin
« Reply #43 on: 10 Feb '22 - 11:14 »
I'm sure there is a way to remove the dependencies but I'm not sure what that is, I may just compile it in Visual Studio 2019+ so presumably you would have the runtime in that case anyway.

For now however attached is a version of xmp-justlog1.8.2 that has been compiled in NetBeans instead so has no visual studio dependencies albeit at the cost of being quite a bit larger. Note that I have not testing this compiled version very much but it seems to work okay in a quick play around.

Just a FYI, there is a bug I'm aware of in JustLog that prevents relative pathing from working correctly if you use certain visual plugins, I'm not 100% sure why that is but I know the fix, just need to get around to doing it.


New version available with fixes and tweaks below.
« Last Edit: 10 Feb '22 - 17:13 by Keltic Danor »

saga

  • Posts: 2615
Re: Xmp-justlog plugin
« Reply #44 on: 10 Feb '22 - 13:35 »
Quote
I'm sure there is a way to remove the dependencies but I'm not sure what that is
You need to set the Runtime Library property of the project to "Multi-Threaded (/MT)" instead of "Multi-Threaded DLL (/MD)". Note that for debug configurations this should typically be "Multi-Threaded Debug (/MTd)" instead.
The resulting DLL will be a bit larger but it won't have any dependencies on the MSVC runtime. The advantage of using the runtime DLL is that this overhead is instead shared between all applications that use the same MSVC runtime, so all in all reduced disk usage at the expensive of having to install a separate component.

Keltic Danor

  • XMPlay Support
  • Posts: 881
Re: Xmp-justlog plugin
« Reply #45 on: 10 Feb '22 - 17:11 »
v1.9
  • Compiled with /MT flag to remove runtime dependencies
  • Relative paths should now always work relative to XMPlay.exe
  • Config now has a path display and test button to show view relative paths easier
Just Log v1.9
GitHub Source Updated

Thanks saga, you're a legend. 8)
« Last Edit: 13 Feb '22 - 08:44 by Keltic Danor »