Topic: XMPlay Last.fm/Audioscrobbler plugin (xmp-scrobbler)

[yagood]

(...)
P.S. 2yagood: there are a LOT of changes in code (: You won't recognize your plug-in! Also there are a lot of comments to help You out. I'd like to say, that my code is FAR from good and needs a lot of cleaning since I did not use C/C++ for many years. That would be nice if You clean it just a bit. Also it would be very nice if You help me find out why my bugs do occur. Maybe not why, but how to fix them - I know why (: But did not figure out yet how to fix.

OK, thanks, I'll take a look at your code, merge changes and release new xmp-scrobbler ASAP. And of course a big "thank you" for your work, great stuff!

P.P.S. 2yagood: I've sent three e-mails to You from my e-mail aux@hexmode.org, did You get them?

OMG, I'm so sorry that you got no response, my spam filter harvests too many e-mails lately, I have to reconfigure it Today it's more like "check spam for mail" than "check mail for spam" Sorry once again...

[Aux]

It's me again! I've made version 0.5zz! Yeah (: And the source is here. Version 0.5zz removes those nasty bugs and also some optimizations were made to save A LOT of processor cycles! And this is great! Yagood, please download 0.5zz for merging - this version is much better!

P.S. yagood, i just sent You two mails (:

[z0id]

i have test latest version
your plugind add @ suffix to artist name
"Liquid Blasted@" instead of "Liquid Blasted"

Code: [Select]

2006-10-30 18:46:06 [DEBUG] DSP_New()
2006-10-30 18:46:27 [DEBUG] DSP_NewTrack (OPEN)
2006-10-30 18:46:27 [CACHE] Number of entries in cache: 0
2006-10-30 18:46:27 [LIBSCROBBLER] ...
2006-10-30 18:46:27 [DEBUG] XMP_FetchInfo -- start
2006-10-30 18:46:27 [DEBUG] XMP_InitDde
2006-10-30 18:46:27 [DEBUG] XMP_InitDde -- after DdeInitialize (instID = 33555585)
2006-10-30 18:46:27 [DEBUG] XMP_GetChannelData (instID = 33555585, ch = info1)
2006-10-30 18:46:27 [DEBUG] XMP_GetChannelData -- after DdeCreateStringHandle (instID = 33555585, hszService = 49153)
2006-10-30 18:46:27 [DEBUG] XMP_GetChannelData -- after DdeCreateStringHandle (instID = 33555585, hszTopic = 49155)
2006-10-30 18:46:27 [DEBUG] XMP_GetChannelData -- before DdeConnect (instID = 33555585, hszService = 49153, hszTopic = 49155)
2006-10-30 18:46:27 [DEBUG] DdeCallback (uType == 33010, uFmt = 0)
2006-10-30 18:46:27 [DEBUG] XMP_GetChannelData -- after DdeConnect (hconv = 67112321)
2006-10-30 18:46:27 [DEBUG] XMP_GetChannelData (id = 33555585, ch = info1, hconv = 67112321, hdata = 117445377, hszService = 49153, hszTopic = 49155)
2006-10-30 18:46:27 [DEBUG] DdeCallback (uType == 33010, uFmt = 0)
2006-10-30 18:46:27 [AUX] info1:

ID3v1:
Title Blunt Light Sabre
Artist Liquid Blasted
Album Back In USSR Vinyl
Year 2004
Genre Hardcore
Comment Frenchcore @ SQ


2006-10-30 18:46:27 [DEBUG] XMP_ParseTrackTags
2006-10-30 18:46:27 [INFO] No valid MusicBrainz ID found, consider using MusicBrainz taggers to tag this file properly!
2006-10-30 18:46:27 [DEBUG] XMP_FetchInfo -- end
2006-10-30 18:46:28 [LIBSCROBBLER] Handshaking: Client up to date.
2006-10-30 18:46:28 [LIBSCROBBLER] Submit interval set to 1 second(s).
2006-10-30 18:46:28 [LIBSCROBBLER] Handshake successful.
2006-10-30 18:49:53 [AUX] JUST SUBMITTED! c_track = 0
2006-10-30 18:49:53 [DEBUG] XMP_SubmitProc start
2006-10-30 18:49:53 [CACHE] AddTrack (cache_size = 0, tracks_size = 10)
2006-10-30 18:49:53 [LIBSCROBBLER] Preparing submit string - package size: 1
2006-10-30 18:49:53 [LIBSCROBBLER] Submitting cache...
2006-10-30 18:49:53 [LIBSCROBBLER] ...
2006-10-30 18:50:06 [LIBSCROBBLER] Submission succeeded.
2006-10-30 18:50:06 [LIBSCROBBLER] Submit interval set to 1 second(s).

[z0id]

seems to be CUE works fine
but simple mp3 not (see post before)

[Killbot]

Got 0.5zz and XM 3.3.
When the scrobbler is activated, it always crashes the whole player, if deactivated, XM works fine.

The Log reads this:

Code: [Select]

2006-10-31 00:24:02 [DEBUG] DSP_New()
2006-10-31 00:24:05 [DEBUG] DSP_Free()
2006-10-31 00:24:06 [DEBUG] DSP_New()
2006-10-31 00:24:08 [DEBUG] DSP_NewTrack (OPEN)
2006-10-31 00:24:08 [DEBUG] XMP_FetchInfo -- start
2006-10-31 00:24:08 [LIBSCROBBLER] ...
2006-10-31 00:24:08 [DEBUG] XMP_InitDde
2006-10-31 00:24:08 [DEBUG] XMP_InitDde -- after DdeInitialize (instID = 33555585)
2006-10-31 00:24:08 [DEBUG] XMP_GetChannelData (instID = 33555585, ch = info1)
2006-10-31 00:24:08 [DEBUG] XMP_GetChannelData -- after DdeCreateStringHandle (instID = 33555585, hszService = 49153)
2006-10-31 00:24:08 [DEBUG] XMP_GetChannelData -- after DdeCreateStringHandle (instID = 33555585, hszTopic = 49154)
2006-10-31 00:24:08 [DEBUG] XMP_GetChannelData -- before DdeConnect (instID = 33555585, hszService = 49153, hszTopic = 49154)
2006-10-31 00:24:08 [DEBUG] DdeCallback (uType == 33010, uFmt = 0)
2006-10-31 00:24:08 [DEBUG] XMP_GetChannelData -- after DdeConnect (hconv = 67112321)
2006-10-31 00:24:08 [DEBUG] XMP_GetChannelData (id = 33555585, ch = info1, hconv = 67112321, hdata = 117445377, hszService = 49153, hszTopic = 49154)
2006-10-31 00:24:08 [DEBUG] DdeCallback (uType == 33010, uFmt = 0)
2006-10-31 00:24:08 [AUX] info1:

ID3v1:
Title Naked Sun
Artist Trail of Dead
Album So Divided
Year 2006
Track 4
Genre Rock

ID3v2:
Title Naked Sun
Album So Divided
Year 2006
Track 04/11
Genre Rock
Encoder Exact Audio Copy   (Burst mode)
Artist ...And You Will Know Us by the Trail of Dead


2006-10-31 00:24:08 [DEBUG] XMP_ParseTrackTags
2006-10-31 00:24:08 [INFO] No valid MusicBrainz ID found, consider using MusicBrainz taggers to tag this file properly!
2006-10-31 00:24:08 [DEBUG] XMP_ParseTrackTags
2006-10-31 00:24:08 [LIBSCROBBLER] Handshaking: Client up to date.
2006-10-31 00:24:08 [LIBSCROBBLER] Submit interval set to 1 second(s).
2006-10-31 00:24:08 [LIBSCROBBLER] Handshake successful.


[Aux]

2 KillBot: ok, i've built version 0.5.0.1. This will be new versioning system for my versions of plug-in until yagood merges our work in 0.6.

2 z0id: can You put your MP3 file somewhere? My music is submitted without any errors (You can check my profile - sb16 at last.fm ). I will check plug-in with your MP3 and fix the problem.

[Killbot]

2 KillBot: ok, i've built version 0.5.0.1. This will be new versioning system for my versions of plug-in until yagood merges our work in 0.6.

Thanks, that one works.

However, I get the same problem like with the 0.5b .dll:

Code: [Select]

2006-10-31 13:44:36 [CACHE] AddTrack (cache_size = 6, tracks_size = 10)
2006-10-31 13:44:36 [LIBSCROBBLER] Preparing submit string - package size: 5
2006-10-31 13:44:36 [LIBSCROBBLER] Submitting cache...
2006-10-31 13:44:36 [LIBSCROBBLER] ...
2006-10-31 13:44:36 [LIBSCROBBLER] Submission failed: bad authorization.
Something like this has been posted here before, but without a final solution.

I've entered my last.fm account data correctly and don't use a proxy server.

[z0id]

2 Aux
my mp3 - http://www.sendspace.com/file/i5e6pi
my last.fm user - paravozik

[Killbot]

I take half of my previous post back - it turned out to be a plain wrong password.

Works now.

[Aux]

z0id, I think that problem is that XMPlay sends us info in unicode (utf8), but we do not handle it. I will fix it when I get some free time - I have a lot of work right now, sorry. I hope for this weekend (:

[z0id]

10x Aux
xmplay damn best

[Aux]

Hey guys, I'm really busy at the moment, but I've found a way to fix all unicode issues (some of my MP3s crash XMPlay!). When it will be done - don't know. I hope for the next week. So stay tuned.

[amit]

I have a couple of questions :

• Can the musicbrainz search be used only when track info is missing ? many times tracks from cds with full information are not submitted because their ID is not found in musicbrainz .Maybe an option can be added to disable the use of musicbrainz completely??
• I get "No valid MusicBrainz ID found" for every cd i play. Does it use the proxy if entered in configuration ?

[amit]

Cosidering Audio quality issues I asked Ian if audioscrobbler plugin is cosidered as an audio modifying dsp (http://www.un4seen.com/forum/?topic=6087.msg42754#msg42754).
He answered that "DSP_Process" function in the plugin code should return 0 in order to not affect other audio processes in the player.
 

A DSP plugin such as audioscrobbler would be considered as a regular dsp plugin for that matter?

Yep, looking at the audioscrobbler code, it would currently be assumed to be modifying the data. That would be changed by its "DSP_Process" function returning 0

Can you fix this please as Ian suggested?

Thanks.

[yagood]

I have a couple of questions :

• Can the musicbrainz search be used only when track info is missing ? many times tracks from cds with full information are not submitted because their ID is not found in musicbrainz .Maybe an option can be added to disable the use of musicbrainz completely??

Xmp-scrobbler doesn't do any MusicBrainz lookups in the current version, it uses MusicBrainz data that is provided by XMPlay from ID3 tags. Also tracks without MusicBrainz IDs should be submitted, MBID is not a requirement. Could you provide your log file?

• I get "No valid MusicBrainz ID found" for every cd i play. Does it use the proxy if entered in configuration ?

In the current version it is impossible to get MBIDs for CD tracks, because XMPlay doesn't provide them for CDs, only for MP3 files tagged with MusicBrainz software.

About DSP_Process - this will be fixed in the next release, thanks for noticing it.

[ec8or]

What's new? CUE sheets are FULLY supported! Files without CUE are ALSO supported (: Everything else is same as it was before me.

just wanted to say thanks.. work perfect, i suspect my last.fm listened songs will show a dramatic growth in the coming weeks...

[yagood]

I just wanted to say that I've just found a bug that sometimes causes failures in submitting big cache files (few dozen cached tracks). So if you see something like...

"FAILED Plugin bug: Not all request variables are set - no POST parameters."

...in your log file, then it's a bug. I'll try to release new version as soon as possible, I have yet to merge aux's CUE changes, sorry that it takes so long...

[Rah'Dick]

Just let me know when the plugin is ready for a release...

[Aux]

yagood, we need to stop using STRING type, because it is not UTF8 compatible. I'll try to rewrite code to use char[] only minding UTF-8 nature.

[yagood]

yagood, we need to stop using STRING type, because it is not UTF8 compatible. I'll try to rewrite code to use char[] only minding UTF-8 nature.

Feel free, I'm out of time.

[Aux]

Me too, but I hope for this weekend.

[Aux]

hi guys! plugin is not dead (: i made 50% of code unicode-friendly tonight, so it is quite possible to see new version this weekend. stay tuned!

[Zarggg]

Weekend is almost over for me. Any progress yet?

[amit]

Aux , Can you also fix the "dsp_function" value I mentioned earlier ?

Cosidering Audio quality issues I asked Ian if audioscrobbler plugin is cosidered as an audio modifying dsp (http://www.un4seen.com/forum/?topic=6087.msg42754#msg42754).
He answered that "DSP_Process" function in the plugin code should return 0 in order to not affect other audio processes in the player.
 

A DSP plugin such as audioscrobbler would be considered as a regular dsp plugin for that matter?

Yep, looking at the audioscrobbler code, it would currently be assumed to be modifying the data. That would be changed by its "DSP_Process" function returning 0

Can you fix this please as Ian suggested?

Thanks.

[yagood]

Weekend is almost over for me. Any progress yet?

I finally have some free time in coming days, so I'm going to finish Aux's work this weekend, add some previously requested features from "to do" list, fix couple of small bugs maybe and there's going to be a xmp-scrobbler 0.6 release very shortly. Thanks for your patience