xmp-openmpt: An XMPlay input plugin based on OpenMPT

Started by saga,

Dotpitch

Quote from: piovrauzI've installed the winamp plugin, got some .mt2 (full package of the tracker), put priority on the WA plugin, but it doesn't decode them. ... I would say it's something on the plugin side, or WA related, since it doesn't display config window too...
Ah, that sounds similar to these issues with in_vgm. Ian, what's going on here?

manx_

Quote from: deus-exThough any changes to the settings aren't saved permanently (at least this does not work for me).

This should be fixed in r3538. Could you please check if http://buildbot.openmpt.org/builds/auto/libopenmpt-win32/libopenmpt-win32-r3538.7z works for you?

manx (libopenmpt developer)

piovrauz

manx_, can you please link that faq? or include it in the libOpenMPT archive? This thread has just the r3532 dl link. ;)
Saga can fix the thread, but if the docs were in the lib archive it would be easier for new users. Thanks.

saga

I've added a link to the FAQ in the first post, although all it requires is to just scroll down a bit on that page. ;)

piovrauz

Nice, you know, there are a lot of lazy ppls! XD
Anyway, I just noticed there's a link to most recent rev in that page too, I didn't see it first time.

saga

Regarding the MT2 issue, it seems to be rather random which plugin takes the file for me.
Testing it using another worlds always makes in_mt2 handle the file if MT2 is specified as priority filetype. Using Andromeda.mt2, xmp-openmpt takes the file. But when removing xmp-openmpt, in_mt2 will also try handling the file. I say "try" because the file will remain silent just like in xmp-openmpt, most likely because it was made in a too recent version of MT2.

Ian @ un4seen

Quote from: piovrauzI can confirm somthing is wrong with mt2.
I've installed the winamp plugin, got some .mt2 (full package of the tracker), put priority on the WA plugin, but it doesn't decode them.
OpenMPT plugin still gets to decode them (well, I hear silence when they play :P).
I would say it's something on the plugin side, or WA related, since it doesn't display config window too...

I'm not sure if it's that XMPlay does something it doesn't expect, but I've always found the Winamp MT2 plugin to be a bit dodgy, where it will often not generate any data on the first use of it. I suspect what's happening here is that the Winamp MT2 plugin is tried first when it has priority for the "mt2" filetype, but it doesn't generate any data so XMPlay goes on to try other plugins. If you try playing the MT2 file a 2nd time, does the Winamp plugin handle it then? Anyway, here's an XMPlay update for you to try, which will automatically ask the Winamp plugin to try again if it doesn't generate any data the 1st time...

   www.un4seen.com/stuff/xmplay.exe

While looking into this, I found that the xmp-openmpt plugin would crash with some MT2 files. Here's an example troublesome file...

   ftp.modland.com/pub/modules/Mad%20Tracker%202/Looza/streets.mt2

saga

Thanks, I'll look into it. The MT2 loader is old and rusty and requires some serious rewrite. :)

And indeed, the latest update seems to help with the MT2 plugin being used instead of xmp-openmpt.

Knurek

Quote from: Ian @ un4seenWhile looking into this, I found that the xmp-openmpt plugin would crash with some MT2 files. Here's an example troublesome file...

   ftp.modland.com/pub/modules/Mad%20Tracker%202/Looza/streets.mt2

Ian, any chance you could backport xmp-openmpt pattern display tech? It shows all those fancy commands/samples/etc used and looks just lovely.

piovrauz

Knurek

I've noticed something while trying the patter display vis with various modules - Basehead's "the zen garden.s3m" has noticeable clicks roughly 0:35 in when compared to XMPlay's replayer.

My settings:
Samplerate: 48kHz
Interpolation: 8 tap
Volume ramping: default

I can prepare wavewrites of the section for you if you can't replicate, maybe it's just some combination of EQ+Rev I'm using...

saga

It's a known issue that is going to be resolved eventually but requires a lot of work to fix properly. FWIW, the clicks won't appear if you disable interpolation.

Lunar07

saga - Every project has to have an outline and a purpose.
Regardless of whether you do it on your own time, for fun and for some other reason.
You have a real life.  We all do. 
This "it is too bad" from you gives openMPT a bad reputation.
Just because you do it for fun is no reason whatsoever for this attitude.
Things have to be done right.
Otherwise, do it ****on your time****

Right now, the issue is this: your plugin insists on playing MT2 files.
And you KNOW quite well that the major formats are INTEGRATED into xmplay.

This means that while someone was doing the coding **for fun** did not think that many formats are natively supported by XMPLAY. And there maybe other plugins out there like MadTracker dedicated plugin.

And all this just not to add a File Extension Selector/Deselector into Config.

Well, yes it is just too bad.  I removed your plugin.  I can actually live without it and without your attitude.

piovrauz

@Lunar07: if you want to see ppl with attitude, I can point you some irc mods. Saga? He doesn't even bite (me, at least for now).
  Are you really expecting someone do something the way you like, even if there's no good reason in his eyes, for free. and using this tone on top of it?
  Last time I checked you were using an OS you paid good money for, made by a company tha does not care about what their users want. Real life.
  Btw: libopenmpt is a lib from a tracker, not just a plugin. I'd say the plugins are like bonus...
  You don't like it? It's open source add patches, fork, code one yourself, whatever.

This said, I'll do what you aren't doing (trying the new rev of XMPlay that should deal with the issue with .mt2).
Just wait I eat something, okie? ;)

Sajadi

Great Job, sounds nice :) Now i look forward for being able to save settings too :D

saga

Quote from: Lunar07Well, yes it is just too bad.  I removed your plugin.  I can actually live without it and without your attitude.
Got no problem with that at all. Maybe it will save us from feature requests about things that can already be done. Just because you think that something should be implemented in a way so that every plugin developer has to re-implement it on their own, that doesn't automatically mean that it's the better way. Because, frankly, it isn't. What Ian implement in XMPlay is much better than other player's approach where it's up to the plugins, and as we all learned now, it's all due to a quick in the MT2 plugin that it didn't work the way you hoped it to work, but the latest version of XMPlay already works around this quirk.

piovrauz

@ SaphirJD: with last rev (r3552 I think) you should be able to save settings, or at least it seems I can (just tried putting mon output).

@ saga: let it go, he won't get that the filetype priority is good as is, he just want a config for filetype to support in the plugins, and he doesn't realize that he basically wants every plugin developer to implement it like that, which means a lot of (now uneeded) work; Ian took care of it at the source, so what's the problem?

Oh, I said I'd do the tests. I forgot, doing them NOW.

piovrauz

Feedback on "Ian Update":

I tried some .mt2 from the tracker package: one, namely "Eternal Engine - Another Worlds.mt2", plays with no issues (using the WA plugin).
Sadly most of them are silent in XMAPlay and WA too, and often crash XMPlay and WA, like "cg_mt2demo_3domo.mt2" and "XnmE-Nuclear_Secret" does.
+Also, playing those with xmp-openmpt doesn't crash XMPlay or WA, they just play silent.
So nothing really related to the xmp-openmpt plugin in the end. Probably some special features of the tracker aren't supported by its WA plugin.

Ah! 2 other things:
1) In the directory you have to make a sub-directory named in_mt2, and put there the contents of Madtraker\Extensions, the .mtx files. This will change the sound a bit.
2) I can't seem to open the config window of this plugin. Nor in XMPlay nor in WA. Bummer.

saga

Quote from: piovrauzSo nothing really related to the xmp-openmpt plugin in the end. Probably some special features of the tracker aren't supported by its WA plugin.
The plugin is much older than the last version of MT2 and very unstable in general. It's not a big surprise. Besides, the plugin will most likely not support VST plugins, which will explain some of the silence, but not all. Basically, I'd guess that the plugin only supports MT2 files up to version 2.0 properly, based on its behaviour.