xmp-openmpt: An XMPlay input plugin based on OpenMPT

Started by saga,

saga

Quote from: guestThis MED sounds different even than in MED Soundstudio for Windows.
This is now fixed, and hopefully doesn't break any other modules (given that it's OctaMED, that is highly unlikely though ;D )

guest

There are differences in the playback of this FC13 module at 0:07-0:09, 0:10-0:12, 0:13-0:14 and 1:11-1:16 (instrument 6 in position 28, 29).

saga

Oops, I tested a couple of files exposing the same problematic notes and they were fine during development, seems like I changed something towards the end that broke them. Those notes should work correctly again.

guest

Quote from: saga
Quote from: guestThis MED sounds different even than in MED Soundstudio for Windows.
This is now fixed, and hopefully doesn't break any other modules (given that it's OctaMED, that is highly unlikely though ;D )

Plugin does not play bassdrum starting from 1:09.

saga

I hear the bass drum just fine here with the latest version. It happens to be affected by the same bugfix I made for the Future Composer file.

saga

This was caused by the Amiga resampler being used for MED files by default, and this sample (plus a few others in that file) contains stereo samples with identical but phase-flipped data on the two sample channels. Since the Amiga resampler does not support stereo samples, they are downmixed to mono, which causes the left and right channel to be added together and effectively cancel each other out. The Amiga resampler is now disabled for MED files with stereo samples.

saga

This should now be playing correctly. I also found that in the aftermath of the previous FC/MED fix, instruments were now completely detuned in XM files with linear slides and a few other formats; this is now fixed as well.

saga

Oh joy, another one of those undocumented behaviours that even differ between OctaMED versions (the Windows version plays the file too slow). I have added a workaround for software-mixed files in SPD mode trying to use a tempo value less than 10, but no idea if once again it's too general or too specific.

saga

Seems like there is yet another opaque condition when volume command parameters are 7-bit vs 6-bit... This is fixed now based on some behaviour changes I found in MED Soundstudio for Windows, as always there is no way to be sure if this is correct though or if it breaks other modules.

saga

Quote from: guest• Looped sample 6 on channel 4 plays differently in Scream Tracker 2.3
Apparently ST2 does not sanitize the loop end, so the sample loop continues playing into the next sample. This is now emulated.

saga

Okay, here's another attempt at guessing when to enable 7-bit volumes and when not to. This should fix instrument 15. Instrument 27 is not fixable with OpenMPT's current pattern effect architecture.

saga

I found a way to slightly improve playback of instrument 27, it's not accurate but better than before.