xmp-openmpt: An XMPlay input plugin based on OpenMPT

Started by saga,

saga

We could call it "no interpolation" as well. Nearest-neighbour sampling is just another equivalent term for that. You cannot interpolate anything with just one tap, you need at least two (linear interpolation). :)

Dhry

Quote from: sagaWe could call it "no interpolation" as well. Nearest-neighbour sampling is just another equivalent term for that. You cannot interpolate anything with just one tap, you need at least two (linear interpolation). :)
Oh. There are still some noticeable sound quality differences between the two, possibly not because of the interpolation then. I typically just listen to SID music anyway, only downloaded and installed the OpenMPT plugin after seeing the OpenMPT program itself (from the link in your sig!) and being reminded of the days when I used to write mods..

Dhry

saga

Well, I have no idea what MT2 does internally, but generally the difference between various sampler implementations without any kind of interpolation should be insignificant (compare e.g. XMPlay's no interpolation mode and OpenMPT's, it should sound more or less the same). Maybe the MT2 plugin uses linear interpolation in fact, which is still a bit "fresher" with old low-quality samples than "better" interpolation algorithms but not quite as crispy as no interpolation at all. And as said before, OpenMPT's MT2 support is old and buggy and really needs to be rewritten, so there are many more little details which could result in this difference.

manx

xmp-openmpt 0.2.3566-beta2 is released, which basically contains the settings-related fixes discussed here, a MT2 loader crash fix and various DBM playback improvements.
http://lib.openmpt.org/files/libopenmpt/bin/libopenmpt-0.2.3566-beta2-bin-win32.7z

Sajadi

The plugin gets better and better, keep on continuing the awesome work on it :) Thanks for all the effort :)

Small additional information... Have experienced right now something strange.. after downloading from the amp dascene amiga music page the track guitar slinger i was not able to play the song properly with the plugin as i renamed it into Guitar slinger.mod - but it was played correctly without mistake with its original name out of the archive file: mod.guitar slinger

Some strange bug perhaps? :D

Dhry

Thanks for the update!
There are some definite idiosyncracies in playback between openmpt and in_mt2. For example in this file, openmpt throws in a huge amount of volume at ~13 seconds in. in_mt2 plays it fine. It's really not too big of a deal for me as I play these files so infrequently, but just thought I'd point out that I agree with saga re: the playback code needing to be revisited. Thank you also for indicating "none" in the 1-tap interpolation dropdown row.  :)

Quote from: Ian @ un4seenThe size of the "Priority filetypes:" text area was automatically defined by Visual Studio (so was the "Supported filetypes:" text area which is fully visible in your screenshot). I don't think enlarging areas for specific fonts is the answer, as what if some other font comes along that requires even bigger areas? I don't think the contents of the options window should be affected by the Windows font settings anyway. To investigate, please confirm the Windows version and exact font settings (including size) that you're using to produce the problem.
Ian, I'm using Tahoma 8-point font under Windows 7 Ultimate x64 SP1. The actual method to change the system dialog fonts is to edit the registry, specifically the HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows NT\CurrentVersion\FontSubstitutes key, and the MS Shell Dlg and MS Shell Dlg 2 string entries. Changing these back to the originals causes XMPlay's dialog text to display fine again. The font point size is not defined anywhere that I can see, just the font name itself.

Dhry

saga

Quote from: DhryThanks for the update!
There are some definite idiosyncracies in playback between openmpt and in_mt2. For example in this file, openmpt throws in a huge amount of volume at ~13 seconds in. in_mt2 plays it fine. It's really not too big of a deal for me as I play these files so infrequently, but just thought I'd point out that I agree with saga re: the playback code needing to be revisited. Thank you also for indicating "none" in the 1-tap interpolation dropdown row.  :)
Yeah, it seems like the current loader doesn't import the channel volume... Not sure whether it's worth hacking that into the existing loader or just waiting until I rewrite it completely anyway.

Edit: Fixed, just redownload the latest development version from the site.

manx

Quote from: SaphirJDSmall additional information... Have experienced right now something strange.. after downloading from the amp dascene amiga music page the track guitar slinger i was not able to play the song properly with the plugin as i renamed it into Guitar slinger.mod - but it was played correctly without mistake with its original name out of the archive file: mod.guitar slinger

XMPlay decides which plugin to use by looking at the file extension. In the case of amiga-style extensions at the front of the filename (as in "mod.guitar slinger"), there is none (or at least, ".mod" is not the extension at the end). As xmp-openmpt cannot be prioritized here, xmplay falls back to using its internal mod player. If "mod" is in your priority file types settings for xmp-openmpt, the renamed file ("guitar slinger.mod") will be played back via xmp-openmpt (xmp-openmpt indicates this in the status lines of the main xmplay window "(via openmpt)"). This would explain differences depending on the filename.

However, from a quick check, I did not notice any obvious playback problems with guiter slinger in xmp-openmpt. So I'm not quite sure what the actual problem might be here.

Dhry

Quote from: sagaEdit: Fixed, just redownload the latest development version from the site.
Nice one. The volume issue is definitely gone now. Will need to set up some time to listen to a few more tracks; throwing stuff into boxes for the next couple of weeks as we'll be moving house soon.

Thanks Saga.

Dhry

Sajadi

Quote from: manx
Quote from: SaphirJDSmall additional information... Have experienced right now something strange.. after downloading from the amp dascene amiga music page the track guitar slinger i was not able to play the song properly with the plugin as i renamed it into Guitar slinger.mod - but it was played correctly without mistake with its original name out of the archive file: mod.guitar slinger

Sorry for the late answer. Downloaded again one of the latest builds and tried again, the problem scene in guitar singer is between 1 minute 7 and 1 minute and 12 seconds... Using the normal xmplay playing routine, the song plays normal. While on the openmpt plugin the song hangs during that time frame. Just compare it with your plugin and the normal xmplay routine.

Same i have also experienced with other mod files, trying again some in the next few days and report them here.

Edit: Another not 100% correct working file is Endless, also from Jogeir Liljedahl. Compare the music part at 4:30 minutes in playback between your plugin and the xmplay playing routine and same song at 7:06 - 7:20, yours is playing that parts slower then xmplay and the samples sound somewhat strange.

So... something bugs at least at Jogeir Liljedahl tunes, the question is what's the culprit :D

saga

Thanks for the detailed report, there seems to be a little issue with some ProTracker compatibility stuff (which was introduced to fix condom corruption by travolta) that somehow doesn't work as intended. Please try this updated version.

Sajadi

Thanks, that is much better now :D Glad that i was able to help a bit in bug finding process :D

Jimmy Neutron

Quote from: saga(which was introduced to fix condom corruption by travolta)

John Travolta corrupts condoms?

saga

Jimmy Neutron

Quote from: sagaYeah, and we're trying to work around that.

Phew!  I'm glad to hear that.

deus-ex

manx

xmp-openmpt 0.2.3746-beta3 is released. http://lib.openmpt.org/files/libopenmpt/bin/libopenmpt-0.2.3746-beta3-bin-win32.7z.
Contains MOD and XM playback and loader improvements in some corner cases, fixes clicks in certain sample loops, and other assorted bug fixes.

tongub

hello. i love the work you've done with this plugin, it adds a lot of great formats to xmplay. i have one question though, are there any plans to update the handling of mmd3 files, as they don't seem to play accurately. thank you for any help you can give.

saga

I planned on replacing the MED loader with xmp's implementation, but it's a lot of tedious work.