▲

[sveakul]

@Keltic:  I forgot to mention in my post about OPUS files not showing embedded cover art that SOME FLAC files also will not show embedded art, and some do.  I PM'd you a link to download examples of all.  Thanks for taking a look at this.

[Keltic Danor]

I've messed with the flac side of things a bit, to be honest I'm not entirely sure how it works but enough prodding and I got the sample flacs that I was sent working so give it a try and let me know how it goes.

I have also spent a large amount of time on Opus (or Ogg) support adding those without much luck so far, may be a little out of my depth but I'll give it another shot or two. See latest post.

[sveakul]

Keltic:  tried out .84 and it will display embedded cover art on every FLAC I try now, thanks for fixing that!

Unfortunately, display is still broken for every OPUS file I try.  I hope you will stick with this a little longer, the answer has to be just around the corner after all the work you've already put into it.  Thanks for your efforts.  If it would help having more OPUS files let me know and I'll PM more.

[sveakul]

In .8.4, also just noticed that if the option to enable auto cover download is de-selected on the menu, it only stays that way for the session.  Re-opening XMPlay will re-enable the option on its own.  Work-around: in vis.ini, make sure acd_enabled=0 and then make the file read-only.  This of course may affect other visuals who store settings here.

[Keltic Danor]

-snip- See latest post.

@sveakul It seems to work fine on the Opus file you sent me via PM but it does not work on the one you attached here and I have no idea why. Also note this is specifically for Opus files despite having the same header format as Ogg, if you guys want Oggs supported you'll have to throw a few my way for testing.

This one also no longer has auto-download enabled by default, that's what was causing your setting issue.

[sveakul]

Hi Keltic, just tested .85.  Unfortunately Opus still does not work, with the exception of one group of files from the same source that include the one you mentioned from my first PM.  Also I ran into one Opus file (with art) that would actually crash the plugin (unload it) when playback was attempted.

I am PM'ing you another set of 6 test Opus files, hopefully a larger variety will help.  4 of these have cover art that is not displayed, 1 of them (prefaced WORKS) is from the same batch that worked before, and the last is the one that crashes the plugin (prefaced accordingly).  All of these play normally and display art in Foobar, AIMP, and MusicBee.

Thanks for anything you can come up with.

[garson]

Just tested the latest version, found that it crashes for some radio stations with Discogs enabled.
Also, rarely shows covers (again for radio stations). 

[Keltic Danor]

-snip- See latest post.

Okay so I've learned that the normal practice is for the big image to be broken up into smaller packets and I had to go through and assemble the BASE64 first then decode it, then interpret the decoded data to get the image details. Bit of a mystery why that one batch of files does not split it up like it should, but I do like the fact that the initial Opus file I got working was actually the messed up one.
Most of the Opus files I have now work. @sveakul, two of the ones you sent don't work despite the BASE64 size being the correct size, so I'm thinking the problem is either my BASE64 decode method is causing problems or my method for reading it is wrong. Either way I will have to get Ian or someone else to look at it as I doubt I'll get better than the current implementation by myself.

Crashes should hopefully be fixed as I was doing buffer overflow stuff which should now be sorted when reading Opus tags.

The Embedded Streaming Url option was having issues working out if it was turned on or not, it's not longer an option (although it shows in the list for fun) so if auto cover download is enabled it will always try and retrieve Urls in while streaming music. Looks like the Opus checks was interfering in the process as well for some bizarre reason, but hopefully it won't do that anymore, testing shows it working okay for me. @garson if you still have issues with some stations let me know.

Discogs changed their website and borked the method I use, no idea how to do it properly at the moment but I have put in a fix of sorts, it will no longer crash and it will still retrieve an image if there are matches but it will not be the full quality image we got before. I'll review it in future or just replace Discogs entirely with something else.

[garson]

Thanks Keltic Danor.

No crashes with Discogs but... weird behavior.
Elvis Costello - Watching the detectives, no album cover, it's well known song.

On other radio station, it was some song from Don Henley, it loaded cover Prince - Space. What's even more weird, on same station it's loading just that one cover for any song. 

Radio stations I use are:
https://usa6.fastcast4u.com/proxy/bigfeat2?mp=/1
Asterisk Radio

http://stream.radioparadise.com/flacm
Radio Paradise (flac)

http://stream.radioparadise.com/mellow-flacm
Radio Paradise Mellow Mix (flac)

http://stream.radioparadise.com/rock-flacm
Radio Paradise Rock Mix (flac)

[Keltic Danor]

Radio stations I use are:
https://usa6.fastcast4u.com/proxy/bigfeat2?mp=/1                    Asterisk Radio
http://stream.radioparadise.com/flacm                    Radio Paradise (flac)
http://stream.radioparadise.com/mellow-flacm                    Radio Paradise Mellow Mix (flac)
http://stream.radioparadise.com/rock-flacm                    Radio Paradise Rock Mix (flac)

I'm guessing the discogs lookup is just unreliable now using my quick fix, I'll have a look and just go ahead and replace it with something else, if you have any suggestions I'm all ears.
I was a bit confused at first but it seems the flac streams from radioparadise don't have coverart urls embedded like the aac streams do, wonder why that is.

The above post has been updated with a minor fix to make embedded urls in streams work even if you don't have any other cover art source enabled.

Edit: Actually looking at things again there seems to be decent API's for Discogs, Spotify, Musicbrainz and Last.fm so I may review and add those in the coming few days.

[garson]

Radio stations I use are:
https://usa6.fastcast4u.com/proxy/bigfeat2?mp=/1                    Asterisk Radio
http://stream.radioparadise.com/flacm                    Radio Paradise (flac)
http://stream.radioparadise.com/mellow-flacm                    Radio Paradise Mellow Mix (flac)
http://stream.radioparadise.com/rock-flacm                    Radio Paradise Rock Mix (flac)

I'm guessing the discogs lookup is just unreliable now using my quick fix, I'll have a look and just go ahead and replace it with something else, if you have any suggestions I'm all ears.
I was a bit confused at first but it seems the flac streams from radioparadise don't have coverart urls embedded like the aac streams do, wonder why that is.

The above post has been updated with a minor fix to make embedded urls in streams work even if you don't have any other cover art source enabled.

Edit: Actually looking at things again there seems to be decent API's for Discogs, Spotify, Musicbrainz and Last.fm so I may review and add those in the coming few days.

I've changed streams to aac, and now I can see cover art. But new issue, when I play a stream, and it dowloads (initial) cover, it doesn't change for new songs.

As for cover art sources, I've looked a bit onlinem found Musicbrainz as well. You can take a look at www.allmusic.com as well.

[sveakul]

@Keltic:  Thanks very much for .87.  About 50% of Opus still doesn't display, but that sure beats 100% like it was before you worked on it.  And as far as I can tell, FLAC is TOTALLY fixed.  I appreciate all your hard work!

[Keltic Danor]

-snip- see latest post, releasing properly soon.

Discogs is fixed and should work much better than before, Last.fm added again and they both seem to work quite well.
MusicBrainz also added but I didn't have much success getting a lot of album covers, I do get some cover art but nothing significant, it also seems a little slow. It's plausible I'm looking things up incorrectly but until someone tells me otherwise I'll just assume that's how it is.
This should also fix the issue of it not fetching new covers when a new song plays on stream.
@garson An odd thing you will find is when you play your "Asterisk Radio" the plugin will go and try and fetch the first thing it sees, which just happens to always get matches for "Prince - Space" it should only show for a second so I'm not going to worry about it but figured I'd let you know that you'll be seeing it again sometime.

[garson]

Hey Keltic Danor.

Just tried latest version, I see last.fm and Musicbrainz in the menu, but still doesn't work for me. Asterisk radio still gives me Prince-Space, though cover is in high res now compared to previous version.
Tried with Radio Paradise, still doesn't change cover when song changes. 

Also, noticed something, there might be space for improvement. When I change "tabs" from Visuals to Messages/File Info, and back, looks like it downloads cover again (I see Downloading message)?

And one more question, about Radio Paradise flac, since it doesn't have embedded cover arts, why it doesn't try to search online? I would assume that if there's no embedded cover, plugin should try to search online?

[Keltic Danor]

Can you attach your vis.ini & xmplay.ini for me to try? Maybe its a setting related issue I can check out. Alternatively you can delete all coverart settings in vis.ini instead and try again, maybe try the latest stuff version too just in case.

Not much I can do about the reloading issue as the plugin is being reloaded, one option is to use a skin with the visual display also in the main window (if only small) so it keeps the plugin loaded. What skin are you using? I can do a tweak to it to achieve the same effect without having it visible.

[garson]

Can you attach your vis.ini & xmplay.ini for me to try? Maybe its a setting related issue I can check out. Alternatively you can delete all coverart settings in vis.ini instead and try again, maybe try the latest stuff version too just in case.

Not much I can do about the reloading issue as the plugin is being reloaded, one option is to use a skin with the visual display also in the main window (if only small) so it keeps the plugin loaded. What skin are you using? I can do a tweak to it to achieve the same effect without having it visible.

I am currently on my work laptop, and I can't see vis.ini  I know I have it on my private laptop.
How can I create it?

As for reloading plugin, is this something that Ian could help with? I am using Delta Black skin.
https://support.xmplay.com/files_view.php?file_id=669

I can send you xmplay.ini if needed.

[Keltic Danor]

Vis.ini should just be made by itself by xmplay when using visual plugins so it must be somewhere.  You aren't having to enable auto downloads everytime you start XMPlay right?

[garson]

Weird. I found vis.ini in AppData folder, xmplay folder is in ProgramFiles x86, guess something with Admin permissions.

So I have only this in vis.ini
[coverart]
acd_enabled=1
acd_services=15
acd_searchwith=7

Let me know if you need xmplay.ini as well

[Keltic Danor]

Weird. I found vis.ini in AppData folder, xmplay folder is in ProgramFiles x86, guess something with Admin permissions.

So I have only this in vis.ini
[coverart]
acd_enabled=1
acd_services=15
acd_searchwith=7

Let me know if you need xmplay.ini as well

Interesting... can you try and turn off "Search with: Title" and see what happens?

[garson]

Yeah, works with "Search with: Title" turned off.
But I would thought that more precise search is with Title as radio streams are usually Artist - Title.
Which leads me to Asterisk radio, several minutes ago it was Rolling Stones - Paint it black, cover was wrong, got "Paint it black: An Alt Country Tribute to the Rolling Stones"