new plugin (cmod-xmplay)

Started by herotyc,

herotyc

Reuploaded the dll, should show 1.4.0.0

herotyc

Hi Ian, hope you can help me with one final problem.

When I add a file to my library, it works as expected. But when I play it (from library) it gets the tags updated (overwrites the title that comes from within the module file, I don't want that).

I want to preserve my title.

So, I thought the Override field would help.

I followed the .library format guide and made a python script to help me populate the tags with the correct info extracted from the URL. Then rewrite the .library file.

But apparently I need to set the override flags. I do that but it is not working.

Can you check the script? Is the guide explaining the binary format outdated?

https://github.com/jllodra/cmod-xmplay/issues/9

Thanks

Ian @ un4seen

Quote from: herotycWhen I add a file to my library, it works as expected. But when I play it (from library) it gets the tags updated (overwrites the title that comes from within the module file, I don't want that).

I want to preserve my title.

Did you set the "Title format" to an empty string in the "Titles" options page? When that's done, I don't think the track's formatted title (seen in the titlebar and playlist) should get updated from the tags.

Or do you mean the "title" tag (not the formatted title) is getting updated? If so, setting the "Override" flag should prevent that...

Quote from: herotycSo, I thought the Override field would help.

I followed the .library format guide and made a python script to help me populate the tags with the correct info extracted from the URL. Then rewrite the .library file.

But apparently I need to set the override flags. I do that but it is not working.

Can you check the script? Is the guide explaining the binary format outdated?

https://github.com/jllodra/cmod-xmplay/issues/9

I'm not a Python user myself, so I can't say whether that code is entirely correct, but flag 0x10 should indeed set the "Override" field and prevent tags being updated from the file. If you read back your output library file, do you see flag 0x10 set on all tracks? Does your output library appear to be all working correctly in XMPlay apart from the "Override" field?

herotyc

Quote from: Ian @ un4seenDid you set the "Title format" to an empty string in the "Titles" options page? When that's done, I don't think the track's formatted title (seen in the titlebar and playlist) should get updated from the tags.

Yes, in Options => Title format => blank

The problem is: when I click on a Library song (not playlist song), then the title that shows the library is updated (the formatted title) with the true title of the module file (which I don't really want).

Quote from: Ian @ un4seenOr do you mean the "title" tag (not the formatted title) is getting updated? If so, setting the "Override" flag should prevent that...

Yes, this one also autoupdates :( if no override checkbox is marked.

Quote from: Ian @ un4seenI'm not a Python user myself, so I can't say whether that code is entirely correct, but flag 0x10 should indeed set the "Override" field and prevent tags being updated from the file. If you read back your output library file, do you see flag 0x10 set on all tracks? Does your output library appear to be all working correctly in XMPlay apart from the "Override" field?

The library file output works fine in xmplay. But the checkbox is not marked when I edit the info of any song in the library. That led me think the binary format described was incomplete.

I will try to work a bit more on it. I think I am not doing anything wrong, I followed the description in the support page.

Ian @ un4seen

Quote from: herotyc
Quote from: Ian @ un4seenDid you set the "Title format" to an empty string in the "Titles" options page? When that's done, I don't think the track's formatted title (seen in the titlebar and playlist) should get updated from the tags.

Yes, in Options => Title format => blank

The problem is: when I click on a Library song (not playlist song), then the title that shows the library is updated (the formatted title) with the true title of the module file (which I don't really want).

Just to be clear, the title shown in the library is the file's "title" tag, not the formatted title (based on the "Title format" setting). The formatted title is what's seen in XMPlay's titlebar (and taskbar) and the playlist "Track" column when that's set to "Title".

When "Title format" is blank, the formatted title shouldn't get updated, but the "title" tag still will if "Override" isn't enabled on the track. Are you seeing the title changing in the titlebar/taskbar/playlist too, or only in the library?

herotyc

It was updating only in the library (once I played it for the first time).


---

Btw, I managed to fix my script, mmm... I still think the format explained in the Support page is wrong. I just did some tests with a hex editor and found what to change.

In my case, it was the last byte before the null terminator 00.

0x2E | 0x10 => 0x3E (that made the override checkbox appear)

I think a library in sqlite, xml, or json, would be more friendly.

Thanks!

PS: I added the final script in the github issue + some screenshots if you want to see.

Now I can finally brag about my library :)

Ian @ un4seen

Quote from: herotycI still think the format explained in the Support page is wrong.

Ah yes, I see that page only goes up to version 5, while XMPlay is on version 6 now. I've updated it now, so please check again and let me know if you still have any trouble with it.