Author Topic: Album and Cover Art Vis Plugin (xmp-coverart rev.8, source code) (Read 282523 times)

saga · « **Reply #150 on:** 27 May '13 - 11:34 »

Usually mixing \ and / shouldn't be a problem in Windows...

piovrauz · « **Reply #151 on:** 27 May '13 - 18:12 »

Well, I put the cover.jpg/png and download.jpg/png in that directory (C:\Program Files (x86)\XMPlay\vis), and the black (ugly) defaults are still shown...
So something is wrong... Funny how nobody never noticed! XD

dbz · « **Reply #152 on:** 27 May '13 - 20:48 »

Hmmm.. I didn't know you could put the image in one location and it would work with any files anywhere. So I figured hey, why not try putting it in xmplay's main folder - and what do ya know... it works! The file I used is "cover.jpg" and it's in the same spot as xmplay.exe. Give it a try, and tell me if I'm wrong about this. Wish I had known about this sooner.

Edit: Upon some more testing it appears that the image file has to be in the same location as the xmp-covert.svp file. I just happened to have the sonique file in the same folder as xmplay.exe. When I tried my other setup of xmplay, it failed - and then I realized what was going on. Once I put the image file in with xmp-covert.svp, it worked again. So it doesn't seem to be dependent on the Program Files\XMplay directory - it's relative to wherever you place it. I'm not sure why it isn't working in your case - just be sure they are in the same folder and it should work.

Dotpitch · « **Reply #153 on:** 27 May '13 - 21:29 »

Quote from: dbz on 27 May '13 - 20:48

So I figured hey, why not try putting it in xmplay's main folder - and what do ya know... it works!

That's good news

. Does that solve your problem?

Quote from: dbz on 27 May '13 - 20:48

Wish I had known about this sooner.

Well, it's certainly not the most obvious feature, but it is mentioned in the manual.

Quote from: dbz on 27 May '13 - 20:48

Upon some more testing it appears that the image file has to be in the same location as the xmp-covert.svp file. ... So it doesn't seem to be dependent on the Program Files\XMplay directory - it's relative to wherever you place it. I'm not sure why it isn't working in your case - just be sure they are in the same folder and it should work.

Correct, the plugin is looking for a file in its own folder, 'C:\Program Files (x86)\XMPlay\vis' just happens to be my configuration. The problem I'm having with the default image however is not the path itself, but the plugin using a forward slash when trying to open the file. Windows apparently doesn't like that (checking with cmd results in the same error). I'm on Win7, what Windows are you running?

piovrauz · « **Reply #154 on:** 27 May '13 - 22:15 »

mmm, same here: I put the files in the xmp-coverart.svp location, but they don't get loaded.
I'm on win7 x64, launching XMPlay as admin has no effect watsoever. T_T
Maybe some compatibility modes? But not now, I just realized it's time to sleep.

dbz · « **Reply #155 on:** 27 May '13 - 23:11 »

I still would have liked to have xmp-covert.svp use a better default image without resorting to using a separate image file, but this will do. Try not to laugh too hard, but I'm using Win98SE... yeah and everything uses "\" slashes. Is it a new feature to use "/" slashes as well, in Win7-8? Since this was coded a few years back, that's probably why there's an incompatibility no doubt.

saga · « **Reply #156 on:** 27 May '13 - 23:19 »

Windows has been able to handle forward slashes ever since - even when mixing them with backwards slashes - even on the command line. I can imagine that there are some problems with virtual paths, though, like when you manually put some files into Program Files (or a program without admin privileges does it), these files are actually stored in "VirtualStore" folder. Maybe Windows has problems rewriting this virtual paths when there are forward slashes in it, who knows.

Dotpitch · « **Reply #157 on:** 28 May '13 - 06:32 »

Quote from: saga on 27 May '13 - 23:19

Windows has been able to handle forward slashes ever since - even when mixing them with backwards slashes - even on the command line.

Are you sure? My Windows at least doesn't seem to like them...

Code: [Select]

C:\>type "d:\_dl\test.txt"
This is a test.
C:\>type "d:\_dl/test.txt"
The system cannot find the file specified.

ProcMon screendump attached as well.

saga · « **Reply #158 on:** 28 May '13 - 11:05 »

Code: [Select]

C:\>cd "\Program Files (x86)/XMPlay\Plugins/AdPlug"
C:\Program Files (x86)\XMPlay\Plugins\AdPlug>

C:\Program Files (x86)\XMPlay\Plugins\AdPlug>type "\Program Files (x86)/XMPlay\P
lugins/AdPlug\in_adlib.txt"
AdPlug Winamp plugin v1.8.2 (in_adlib.dll)
[...]

However, it seems that if the last slash in that case is a forwards slash, it doesn't work. That might be a programming error in "type" and also "xmp-vis" (the program looks for a backslash when separating path and file name, or something like that), or it might be an OS limitation. But in the path itself, it doesn't matter as you can see.

Dotpitch · « **Reply #159 on:** 28 May '13 - 17:03 »

Quote from: saga on 28 May '13 - 11:05

However, it seems that if the last slash in that case is a forwards slash, it doesn't work.

Ah, you're right about that

.

Code: [Select]

C:\>type "d:\_dl\test.txt"
This is a test.
C:\>type "d:\_dl/test.txt"
The system cannot find the file specified.
C:\>type "d:/_dl/test.txt"
The system cannot find the file specified.
C:\>type "d:/_dl\test.txt"
This is a test.

Good to know this one!

Barna · « **Reply #160 on:** 7 Jun '13 - 17:47 »

Hey guuuuyyyyys

Piovrauz found a way to contact me, or rather, contact someone who told me to look at that mail inbox :-)

Actually I'm super stoked about people still using XMPlay and my plugins.
Sadly I myself have basically stopped listening to music and thus haven't checked back here in years.
I always wanted to release this and the winamp vis wrapper plugin as open source, maybe I'll get around to do so this time.

For now I fixed the path separator issue which seems weird to me as well, but totally occurred on my new shiny Windows 8 laptop, too. Forcing backslash fixed it as assumed.
Download: http://www.nukular.ch/xmp-coverart_rev.7.zip

I also noticed that each and every auto cover downloader is broken, which sucks. I always liked the amazon source the most but they now require some further draconian signing for their API which requires registration as an Amazon Associate which they say to be free but the registration screen wants to confirm payment details, which scared me away for now :-) Maybe they want money per API use above some limit or something.

Will try to stick around here for a while, make sure to tell me any further big issues. And if someone feels like looking at some rather old and thrown together C/C++ code, I'll make sure to hurry up to put the source up somewhere.

Thanks for sticking around everyone and greetings from Tokyo,
Bernhard

piovrauz · « **Reply #161 on:** 7 Jun '13 - 18:46 »

Hehe, so the mail I sent to the "wrong" address before yours was the one that made it?
Great, now I can enjoy covers again. And nice to see you around btw.

What do you mean by " each and every auto cover downloader is broken"?
I'm pretty sure my obscure metal bands CDs are being identified properly (mmm, lastfm seems to work)...

Anyway, thanks for the update, and also for the winamp vis wrapper, which I use as my only vis. I didn't noticed it was years old till there was this issue with the cover-art. XD

See you around.

Barna · « **Reply #162 on:** 7 Jun '13 - 22:26 »

Glad it works now :-)
Oh, you're absolutely right. LastFM does work indeed. Though it seems to load some covers twice somehow.
Google image search and Flickr stopped working due to them changing their sites.
Amazon stopped working because of API/policy changes as mentioned.

dbz · « **Reply #163 on:** 8 Jun '13 - 00:12 »

Wow, what a nice surprise! Thanks to your efforts piovrauz we're glad to see Barna here again. You probably don't recognize me Barna, but I've been around here long enough to remember you. In fact, I'm the one who kinda resurrected this thread in hopes of an update to the "No Cover Art" image, to something more appealing. Since my post here, others have made me aware that an image in the same location as the plugin will then act as the default "No Cover Art" image. So that works, but I was still hoping for something a little more permanent - such as an edit to the "text" image itself.

Perhaps you could use this image I got from the hydrogenaudio.org forum. As far as I can tell, it was posted by a member of the site for free usage, and made from public domain clipart. So I think it's ok to post this... if not then I apologize and Ian may remove it. Or if you have something similar but better than this, that's cool too

Edit: Ok here was my original idea... to use the xmplay logo image... and thinking about it some more, it's probably the best image to use since it goes with the default skin perfectly, plus not every audio file is necessarily related to a music cd/album cover. A radio interview for instance doesn't really fit with the concept of album art. Another even better example would be short audio samples (not music, but sounds like in tracker songs). In this particular case, album art doesn't make a lot of sense unless it's part of a whole collection of sounds. In these instances the xmplay logo is a generic image suitable for any type of audio - plus it looks real nice

So please use this image, as opposed to the CD image. Oh, and I'll leave the cd image in case anyone finds it of use to them. Thanks.

BTW: this was the largest (256x256) I could find the xmplay logo (http://ncrow.deviantart.com/art/Icon-XMplay-136025061)... the creator of this work has .ico, .png, and .tiff versions included in the zip and he says the .tiff can be scaled to any size. I'm not a graphics expert so I don't know if you could use that, but if anyone has a higher res version and wants to post that, that'd be great. Also if anyone has a totally better idea for an image, feel free to post what you've got or what you think would work best.

saga · « **Reply #164 on:** 8 Jun '13 - 00:31 »

[OT]
I wonder when blank CD images like this one will become as obsolete as "Folder" and "Disk" icons in menu toolbars...
[/OT]

Dotpitch · « **Reply #165 on:** 8 Jun '13 - 09:33 »

Quote from: Barna on 7 Jun '13 - 17:47

Hey guuuuyyyyys

Welcome back!

Quote from: Barna on 7 Jun '13 - 17:47

For now I fixed the path separator issue which seems weird to me as well, but totally occurred on my new shiny Windows 8 laptop, too. Forcing backslash fixed it as assumed.

Thanks for the fix, it works fine now. It's actually quite impressive that it's the first bug in well over 3 years.

Y@nek® · « **Reply #166 on:** 8 Jun '13 - 20:16 »

Great! Thank you for new version.

piovrauz · « **Reply #167 on:** 8 Jun '13 - 21:11 »

The big XMPlay logo/icon will do a great no-cover for me.
Now, What can I use for "downloading"? A faded one? mmm
Since Barna is now around, let's check some newer milkdrop to see if all is fine...

AstralSoup Design · « **Reply #168 on:** 11 Jun '13 - 13:10 »

Bring the action

Here's the icon rescaled to 3000x3000 Pixels.

Chinese Sausage · « **Reply #169 on:** 11 Jun '13 - 16:23 »

Quote from: saga on 8 Jun '13 - 00:31

[OT]
I wonder when blank CD images like this one will become as obsolete as "Folder" and "Disk" icons in menu toolbars...
[/OT]

Let's hope not. A CD is still superior to any .mp3 or other lossy compression format.

Quote from: Nicolas @ b&f on 11 Jun '13 - 13:10

Bring the action

Here's the icon rescaled to 3000x3000 Pixels.

Very nice pic Nicolas!

Quote from: Barna on 7 Jun '13 - 17:47

Hey guuuuyyyyys

Piovrauz found a way to contact me, or rather, contact someone who told me to look at that mail inbox :-)

Actually I'm super stoked about people still using XMPlay and my plugins.
Sadly I myself have basically stopped listening to music and thus haven't checked back here in years.
I always wanted to release this and the winamp vis wrapper plugin as open source, maybe I'll get around to do so this time.

For now I fixed the path separator issue which seems weird to me as well, but totally occurred on my new shiny Windows 8 laptop, too. Forcing backslash fixed it as assumed.
Download: http://www.nukular.ch/xmp-coverart_rev.7.zip

I also noticed that each and every auto cover downloader is broken, which sucks. I always liked the amazon source the most but they now require some further draconian signing for their API which requires registration as an Amazon Associate which they say to be free but the registration screen wants to confirm payment details, which scared me away for now :-) Maybe they want money per API use above some limit or something.

Will try to stick around here for a while, make sure to tell me any further big issues. And if someone feels like looking at some rather old and thrown together C/C++ code, I'll make sure to hurry up to put the source up somewhere.

Thanks for sticking around everyone and greetings from Tokyo,
Bernhard

Thank you for the update Barna!

saga · « **Reply #170 on:** 11 Jun '13 - 17:29 »

Quote from: Chinese Sausage on 11 Jun '13 - 16:23

Let's hope not. A CD is still superior to any .mp3 or other lossy compression format.

So? It has practically no advantage over any lossless format. CDs will become obsolete, it's just the question when the mainstream will finally recognize this.

piovrauz · « **Reply #171 on:** 11 Jun '13 - 17:50 »

well, depends on DRM... or how industry will make us eat DRM. It's all there.

dbz · « **Reply #172 on:** 12 Jun '13 - 15:43 »

Thanks Nicolas for posting a much higher resolution image of the xmplay logo.

dbz · « **Reply #173 on:** 15 Jun '13 - 16:40 »

I guess all we need now, is for Barna to come back again and see what's going on

Matt K. · « **Reply #174 on:** 23 Jun '13 - 08:12 »

Quote from: Barna on 7 Jun '13 - 17:47

Hey guuuuyyyyys

Piovrauz found a way to contact me, or rather, contact someone who told me to look at that mail inbox :-)

Actually I'm super stoked about people still using XMPlay and my plugins.
Sadly I myself have basically stopped listening to music and thus haven't checked back here in years.
I always wanted to release this and the winamp vis wrapper plugin as open source, maybe I'll get around to do so this time.

For now I fixed the path separator issue which seems weird to me as well, but totally occurred on my new shiny Windows 8 laptop, too. Forcing backslash fixed it as assumed.
Download: http://www.nukular.ch/xmp-coverart_rev.7.zip

Good to see you back Barna! (Thanks also for finding him, Piovrauz!) Thanks for the update Barna! Glad to see you pop a quick fix out for those running newer OSs than me (I'm still stuck on XP Pro, but it's starting to feel more like a Commodore 64!) out there...

Quote from: Barna on 7 Jun '13 - 17:47

Will try to stick around here for a while, make sure to tell me any further big issues. And if someone feels like looking at some rather old and thrown together C/C++ code, I'll make sure to hurry up to put the source up somewhere.

Here's hoping the source code follows soon... I haven't coded in quite a while, but this is something I might be willing to dust off my programming knowledge on... I'm guessing my coding can't be any worse than yours Barna...

Quote from: Barna on 7 Jun '13 - 22:26

Glad it works now :-)
Oh, you're absolutely right. LastFM does work indeed. Though it seems to load some covers twice somehow.
Google image search and Flickr stopped working due to them changing their sites.
Amazon stopped working because of API/policy changes as mentioned.

Yes, it'd be nice to have the Google search & Flickr options back. (PLLLllleeeeaaassseee???)

Quote from: dbz on 8 Jun '13 - 00:12

Edit: Ok here was my original idea... to use the xmplay logo image... and thinking about it some more, it's probably the best image to use since it goes with the default skin perfectly, plus not every audio file is necessarily related to a music cd/album cover.

I agree, good idea!

Quote from: Nicolas @ b&f on 11 Jun '13 - 13:10

Here's the icon rescaled to 3000x3000 Pixels.

Thanks! (It looks great!) Now we need a better "Downloading.jpg" file too...