Author Topic: Plugin Update: SIDevo v4.5  (Read 3740 times)

Keltic Danor

  • XMPlay Support
  • Posts: 905
Re: Plugin Update: SIDevo v4.4
« Reply #25 on: 6 Feb '24 - 12:18 »
...I remember that the SIDex version had a rather nice equalizer in it, I was wondering if it would be possible to implement that in this one also?...
I don't have any plans to add that, I don't really get how it works to be honest so it probably wouldn't be a good idea.  :P

Is it possible to wrap these with MultiByteToWideChar() with 1250 code page, so the text is displayed properly on non-latin systems?
I'm not too familiar with the function but I can give it a try, I'm guessing it just converts the buffer given? You can test the below version but otherwise if you give me the code necessary to provide what you need I can put it in for you.

SIDs containing subsongs with STIL file-global comment:
/MUSICIANS/B/Blues_Muz/Bombmania_II_preview_2.sid
/MUSICIANS/D/Daglish_Ben/Jack_the_Nipper_II.sid
I've put in a fix of sorts to try out in the next version. You can test the below version with the change.

I'm having an issue with SIDevo crashing XMPlay when trying to add WavPack files to the playlist.
I was unable to reproduce this with any of the wavpack files I have, if you can provide the trouble one I can check it out? Ian gave me a sample, the below version should fix it?

This version also has the latest libsidplayfp-2.6.0. I'm not sure what the changes are but it seems a bit bigger so they've been up to something.
« Last Edit: 12 Feb '24 - 11:43 by Keltic Danor »

guest

  • Guest
Re: Plugin Update: SIDevo v4.4
« Reply #26 on: 7 Feb '24 - 12:18 »
Could you please share the file for guests?

Keltic Danor

  • XMPlay Support
  • Posts: 905
Re: Plugin Update: SIDevo v4.4
« Reply #27 on: 12 Feb '24 - 11:17 »
Yep, uploaded here for now. Still in testing so not formally releasing it yet.

https://support.xmplay.com/temp/xmp-sidevo.4.5b.zip

v4.5b
- libsidplayfp library updated to 2.6.0
- Fixed issue with subsong STIL setting not getting sid comments
- Fixed tag display on non-latin systems
- Fixed random scanning of invalid files

guest

  • Guest
Re: Plugin Update: SIDevo v4.4
« Reply #28 on: 13 Feb '24 - 10:48 »
The plugin could also display info text from MUS files and words from the accompanying WDS files.
Also, for stereo tunes (MUS+STR), additional format information in the "General" info window.

Keltic Danor

  • XMPlay Support
  • Posts: 905
Re: Plugin Update: SIDevo v4.4
« Reply #29 on: 14 Feb '24 - 08:46 »
The plugin could also display info text from MUS files and words from the accompanying WDS files.
Also, for stereo tunes (MUS+STR), additional format information in the "General" info window.
I can take a look at it, do you know where I can find the file format/specifications for WDS files? I'm not sure how to open them up. And what additional format information are you thinking of?

guest

  • Guest
Re: Plugin Update: SIDevo v4.4
« Reply #30 on: 14 Feb '24 - 09:31 »
MusiQt by drfiemost https://github.com/drfiemost/musiqt
displays comment from MUS file and lyrics from WDS in "Song info" dialog.

guest

  • Guest
Re: Plugin Update: SIDevo v4.4
« Reply #31 on: 14 Feb '24 - 10:47 »
Also, for stereo tunes (MUS+STR), additional format information in the "General" info window.
And what additional format information are you thinking of?

Format    C64 Stereo Sidplayer format (MUS+STR)
Sid Info  #2 - ...



Keltic Danor

  • XMPlay Support
  • Posts: 905
Re: Plugin Update: SIDevo v4.4
« Reply #32 on: 14 Feb '24 - 15:01 »
Format    C64 Stereo Sidplayer format (MUS+STR)
Sid Info  #2 - ...
It doesn't look like libsidplayfp returns when it's using str or not so I can't identify it at the moment through there, I'll have a look at it in future.

-snip-
« Last Edit: 15 Feb '24 - 02:47 by Keltic Danor »

guest

  • Guest
Re: Plugin Update: SIDevo v4.4
« Reply #33 on: 15 Feb '24 - 00:57 »
\Dave_Collins\Pop_goes_the_World.mus
Plugin displays "(null)" in MUS Comments and only the first line of WDS Contents.

\BJ_Pools\Long_Cold_Winter.mus
XMPlay crashes while displaying Message window.

Keltic Danor

  • XMPlay Support
  • Posts: 905
Re: Plugin Update: SIDevo v4.4
« Reply #34 on: 15 Feb '24 - 02:59 »
\Dave_Collins\Pop_goes_the_World.mus
Plugin displays "(null)" in MUS Comments and only the first line of WDS Contents.

\BJ_Pools\Long_Cold_Winter.mus
XMPlay crashes while displaying Message window.

I've revised how I'm loading and treating the WDS to match that other code and it solve the crashes, I've also ignored nulls in comments now.

https://support.xmplay.com/temp/xmp-sidevo.4.5d.zip

v4.5d
- libsidplayfp library updated to 2.6.0
- WDS files are now shown in the Message window
- Comments from MUS files are now showing in the Message window
- Fixed issue with subsong STIL setting not getting sid comments
- Fixed random scanning of invalid files causing crashes

guest

  • Guest
Re: Plugin Update: SIDevo v4.4
« Reply #35 on: 15 Feb '24 - 09:46 »
\DC_Star_and_Cpr\Noel_Time.mus
WDS Contents are not fully displayed.

Keltic Danor

  • XMPlay Support
  • Posts: 905
Re: Plugin Update: SIDevo v4.4
« Reply #36 on: 15 Feb '24 - 15:39 »
\DC_Star_and_Cpr\Noel_Time.mus
WDS Contents are not fully displayed.
Looks like it does work but it has a million new lines in it for some reason, scroll down a bit?

guest

  • Guest
Re: Plugin Update: SIDevo v4.4
« Reply #37 on: 16 Feb '24 - 02:13 »
\DC_Star_and_Cpr\Noel_Time.mus
WDS Contents are not fully displayed.
Looks like it does work but it has a million new lines in it for some reason, scroll down a bit?

The last line should read: "FROM DC STAR" and it is "THE FIRES ARE BURNING ON THE HILL".

Sigma Seven

  • Posts: 14
Re: Plugin Update: SIDevo v4.4
« Reply #38 on: 18 Feb '24 - 21:28 »
Would it be possible to fetch the subtune's NAME field from the STIL and have that inserted in the playlist window using a custom formatting string?

In the options on the 'titles' tab I'm using the following string, which displays " - Tune x" after the SID's title if the SID has a subtune:

%0%?9{ - Tune %9|}

After that we could have the actual NAME of the subtune from the STIL, if there's any.

So for example, these SIDs would look like this in the playlist:

Last Ninja 3 - Tune 3 - Intro Tune
Last Ninja 3 - Tune 4 - Mountains
Last Ninja 3 - Tune 9 - Game Over

Last Ninja 2 - Tune 1 - Central Park (loader)
Last Ninja 2 - Tune 8 - The Basement (in-game)
Last Ninja 2 - Tune 10 - The Office (in-game)

Turbo Outrun - Tune 1 - Intro
Turbo Outrun - Tune 2 - Title
Turbo Outrun - Tune 8 - Level 4

Ultima V-Warriors of Destiny - Tune 1 - Ultima Theme
Ultima V-Warriors of Destiny - Tune 4 - Engagement and Melee
Ultima V-Warriors of Destiny - Tune 7 - Fanfare for the Virtues

I'm guessing for this to work Ian would also need to add a new formatting string, for example 'subsong name' or something like that.

Keltic Danor

  • XMPlay Support
  • Posts: 905
Re: Plugin Update: SIDevo v4.4
« Reply #39 on: 2 Mar '24 - 11:04 »
Not sure about the fancy sub song stuff but I'll have a look some time.

4.5 has been released now, the MUS WDS file conversion isn't perfect. I'm not sure why it doesn't show the full text for that file but I figure the best thing would be to just release it and update the repo and perhaps someone else might have an idea. There are other fixes in this one related to the crash fix which broke something else so even if you are using a previous 4.5 version I would suggest upgrading to the latest.

Change Log
v4.5
- libsidplayfp library updated to 2.6.0
- WDS files are now shown in the Message window
   - The reading of WDS/conversion from PETSCII is far from perfect, any code suggestions would be most welcome
- Comments from MUS files are now showing in the Message window
- Fixed issue with subsong STIL setting not getting sid comments
- Fixed random scanning of invalid files causing crashes

Download
https://support.xmplay.com/files_view.php?file_id=731 Download from XMPlay Support
https://github.com/KelticDanor/xmp-SIDevo Source on GitHub

HavaR

  • Posts: 39
Re: New Plugin: SIDevo v4.1a
« Reply #40 on: 11 Mar '24 - 20:35 »

Can't seem to have the STIL document folder recognized.
I think the path is correct but it always say it's wrong.
the test button doesn't seems to change that.
Is it a relative path or a full one? Let me know what the path is and I'll see if I can work out what is up.

Hi, thank you for your work on this plugin. I have this same problem with a recently downloaded XMPlay 3.8.5 and just a handful of plugins. The path to mine should be correct but says in the settings it is invalid: F:\LYD\00sid\C64Music\DOCUMENTS