SIDex plugin

Started by Keltic Danor,

Sebby75

#140
Quote from: DhryIf KelticDanor hasn't already sent it to you, there's the option of using his version of the plugin as well.
DRS

@DRS
He did... and I am using it as my daily driver.

@Malade
Trying to test it some more now that I have bit more free time this week (YaY !! finally !!).

I am trying to uderstand how are "allow 2nd chip for 1sid" and "force 1sid difference" options supposed to work...
Is the idea that 1st chip is outputting only to left channel and 2nd chip to right channel? Or not??
I remember you had it on by default in past and it created slight offset between waveforms and bit of echoing (which drove me mad).
I'm trying to understand it's purpose and how it is supposed to work...
At the moment when I turn it on and say disable all voices of CHIP2 I can still hear sound in left and right channels (surround is off)
(but maybe this is how it is supposed to work).

Could do with bit of description of new options.. and how they are supposed to work.. instead of leaving it to us to guess and report bugs when something might be actually working as designed.

Not going to rant about OK button not closing option screen and jumping to next song (done too much ranting about that already)... at least it is now resetting song timer to 0:00 :)

Could do with option for automatic surround for multi sid tunes (2sid, 3sid, etc).  Don't know how about others but I always had it on when I used Fraggies plugin..
Probably doesn't matter that much when listening on speakers... but 2sid tunes on headphones are painfull without either surround or pan separation option.
On the other hand I don't like surround on single sid tunes, therefore I don't really want it on for everything.

Could do with song info displayed in options screen to be also shown in general info tab of xmplay.
Default sid type (and one currently playing if forced to be different), Player info.. etc.
It would make sense to make it easier to access...

libsidplayfp was recently updated to version 2.3.1


BUGS (will be adding on if i find any more):
  • When surround is switched on there seem to be a problem with some voices being silent when switching between single sid and multi sid tunes.
    (multi sid tune is missing some voices, i will test some more and give you examples to try)

    Stinsen - Space_Monkeys_2SID   (options used for playback are attached below)
    - played straight after opening xmplay - all sounds fine.   
    - and played again after another sid (single sid tune) - you can clearly hear that some voices are missing
    https://www.dropbox.com/sh/y8bofjascbhoo5l/AABqfGtQh2S8C1D583bz73Cwa?dl=0


  • When playing sid with subtunes, if you turn surround on or off and press OK, playback skips to next subtune which will play at double speed OR sometimes it will crash xmplay



Kindest regards
Sebby

Malade

#141
Hello lads ,

just got back , seen the posts and have just updated to latest libsidplayfp 2.3.1 2021-12-07, checking to see if i can repair what else is wrong , looking right now at this missing voice problem. ( fixed )

dialog staying open fixed.
tune playting at hyper speed ( gerbil wtf ) fixed
2 sid / 3 sid voices abandoning fixed.

force 1sid difference mutes 3 voices then reenables them to allow the fir filter to apply 10 micro seconds behind it i added this to get it sounding like it did back in 88 on an old amstrad stacker system in a brown cabinet , glass font , it had a surround button that i always listened to the music playing from the commodore breadbin on.

allow 2nd sid is to allow voice muting of left and right channels ( stereo but trying to keep the old mono and add slight buffers to the left right for pops and blows etc ) as i noticed libsidplay outputs on dual channels so i thought adding it would make it sound nice.

equaliser , well its an equaliser that changes different frequencies to make the sound of left and right mono slightly different ( its dual channel independent 20db) , i was going to add a 250 band eq but i don't know if the old laptops this could be used on would survive it so i blown it down to 10 x 2 .. 10 for left , 10 for right separately.

i will fix what i can and upload the new version soon. fixed reported problems , new version uploaded with libsidplay 2.3.1 and bug fixes.

btw i just made a playlist generator using sidid , it scans the whole hvsc or single files or folders and builds a m3u playlist with only the certain players , ie mon/ for jch player etc and i will add the timer files for anyone who has a 1541 ultimate II+ so you can play the songs with the right time instead of 5:00 on real hardware etc ( its good for tracking songs from a certain year which you remembered but forgot the name or where you heard it mainly crack intros with me tbh  ), when its finished il polish it up for you lot and release it , btw its dead simple to use , all drag and drop , dead easy peas'y.

right uploading latest version.

new version attached see below.

right laid back in my recliner playing mugsys revenge.

https://www.youtube.com/watch?v=738fJWztWaw

have fun and report any bugs if you find any.

Sebby75

Gave 2.6 quick 5 minute run...

right off the bat that tune I was testing with last time (Stinsen -Space Monkeys) sounds completely wrong... 3rd voice of 1st sid sounds completely different to what it should...
play that voice with sidplayfp.exe -u1 -u2 -u4 -u5 -u6 Space_Monkeys_2SID.sid  to hear what it should sound like

while tune is playing (and multiple tunes in the playlist)
go to options, press OK skips to next tune and plays 2nd sid with no sound at all...
when you go to options and press OK it skips to 3rd one and you can hear sound
and another OK is another skip and 4th sid plays with no sound at all...

that's me done for today :)

regards
Sebby

Malade

Hi sebby,
 thanks for letting me know buddy, il look into it for you when i can , i will tell you though that its playing ok here but i am a few versions above what i last posted , i will have a look into it though and see if i can replicate it.

btw the source is available if anyone would like to have a look or help.

Sebby75

Quote from: MaladeHi sebby,
 thanks for letting me know buddy, il look into it for you when i can , i will tell you though that its playing ok here but i am a few versions above what i last posted , i will have a look into it though and see if i can replicate it.

btw the source is available if anyone would like to have a look or help.

Malade.

Sources on github are 2 months old, could you update to current? Maybe then somebody can look at them and help.

Regards
Sebby


Malade

#145
Hi sebby ,
               i have tried to update to git hub 3 or 4 times with no success, i get 'Failed to connect to github.com port 443: Timed out.' , no idea why.

 the latest version is attached, post back if you can with any bugs or suggestions btw the player core should be rock solid now i have changed the way the plugin inits the tunes and use xmplay stop and restart.

just tried again to update the github , same error , i may upload it here for now.

sourcecode attached.

bloody git hub  ::) , i will update trhe github when i can , meanwhile i have attached the source to this post. latest version 2.0 rev 2.7

Sebby75

#146
I'm going back to same tune Stinsen - Space Monkeys.. have you even listened to it??

Listen to voice 3 of 1st SID... and only that voice...

plugin 2.5 (first run after opening xmplay) - voice 3 sounds correct

plugin 2.6 and 2.7 -- voice 3 sounds completely different

i mean it probably sounds wrong on most of the tunes but this is the one i picked to test earlier today and one that is pretty easy to hear the difference right at the start

https://www.dropbox.com/sh/pepu6o7wkez6n2m/AACYk-e0N6W9W125lQmmEZU3a?dl=0

http://deepsid.chordian.net/?file=/MUSICIANS/S/Stinsen/Space_Monkeys_2SID.sid



Malade

Quote from: Sebby75I'm going back to same tune Stinsen - Space Monkeys.. have you even listened to it??

Listen to voice 3 of 1st SID... and only that voice...

plugin 2.5 (first run after opening xmplay) - voice 3 sounds correct

plugin 2.6 and 2.7 -- voice 3 sounds completely different

i mean it probably sounds wrong on most of the tunes but this is the one i picked to test earlier today and one that is pretty easy to hear the difference right at the start

https://www.dropbox.com/sh/pepu6o7wkez6n2m/AACYk-e0N6W9W125lQmmEZU3a?dl=0

http://deepsid.chordian.net/?file=/MUSICIANS/S/Stinsen/Space_Monkeys_2SID.sid

ive listened to it 5 times .. and both versions ( yes there is 2 versions ..)  and they sound correct to me.

https://deepsid.chordian.net/?file=Exotic%20SID%20Tunes%20Collection/Stereo%202SID/Stinsen/Space_Monkeys_2SID.sid

https://deepsid.chordian.net/?file=/MUSICIANS/S/Stinsen/Space_Monkeys_2SID.sid

ps your folders empty. https://www.dropbox.com/sh/pepu6o7wkez6n2m/AACYk-e0N6W9W125lQmmEZU3a?dl=0

Sebby75

files should be now in the dropbox folder...  named them earlier other way round by mistake...   only difference in setup is plugin version  2.5 vs 2.7

Malade

Quote from: Sebby75files should be now in the dropbox folder...  named them earlier other way round by mistake...   only difference in setup is plugin version  2.5 vs 2.7

ok buddy il have a listen now.

Malade

Quote from: Sebby75files should be now in the dropbox folder...  named them earlier other way round by mistake...   only difference in setup is plugin version  2.5 vs 2.7

clear all your settings somethings wrong with them , this is my output.

https://www.mediafire.com/file/lqoln6znw98t8jt/Space_Monkeys_2SID.sid.mp3/file

Sebby75

yeah.. listening to your output mp3.. it sounds wrong..
disable voice1 and 2 for SID1 and all voices for SID2... you will clearly hear it

Malade

ok buddy il have a listen now.

i hear it now ,i will take a look see.

Malade

#153
checking now , but it looks like the only major changes to between 2.5 and later versions were bells and whistles which should not cause this , and then there is the update to libsidplayfp , il roll back and see. , yep found the bug it was visual studio not compiling changes correctly , il do it tomorrow now , getting late here..

Sebby75

no worries...

but latest sidplayfp was updated to libsidplayfp-2.3.1 and it is playing this tune correctly.

I can't unfortunately tell you what is the problem...
Tried to mess about with filters, digi-boost and even forcing sid to different model... but I could not make it sound that way no matter what I tried to break it...

good luck
Sebby

Malade

#155
Quote from: Sebby75no worries...

but latest sidplayfp was updated to libsidplayfp-2.3.1 and it is playing this tune correctly.

I can't unfortunately tell you what is the problem...
Tried to mess about with filters, digi-boost and even forcing sid to different model... but I could not make it sound that way no matter what I tried to break it...

good luck
Sebby

// New noise waveform output.
     set_noise_output();

this was causing it , sorted it now , players rock solid , everything's working ok , i will test it a bit more then i will push the source and release the final version.

libsidplayfp 2.3.1 build
github:
https://github.com/StronSon/xmplay-sid-plugin-v2.8-final-
final build , full source code on the git ,  simple to update to your latest libsidplayfp ,

added a build bat so its simpler for you to build it , just run the bat it and it will compile.

have fun , all the best and stay safe. :)

i will upload the plugin , 1 moment.

Malade

this will be the final release for a while maybe someone else can take over as i am extremely short on time at the moment real life is encroaching,

final rev 2.8 plugin using libsidplayfp 2.3.1

file is attached to this post , full source code in my previous post.

have fun and enjoy the old tunes , stay safe, all the best. :)

Sebby75

Thanks Malade,

Great update, have some rest from my mithering about this and that :)

Have a Bug Free Christmas and Rock Solid New Year
Sebby ;D

Dhry

Malade - sit back and relax man. Take it easy, have a great Christmas, don't rush things, this can alllll wait. I appreciate every release, and the time you spend on them at your own expense.

Edit: I gotta tell you that 1 and 2 sid surround and the EQ with just the default settings you have it at make SIDs sound pretty god damned good IMO. Really well done.

DRS

saga

Maybe I'm doing something wrong, but the new SIDex plugin doesn't seem to integrate with XMPlay's looping mechanism, so if a SID song would loop it simply stops at the end of the loop rather than jumping back and fading out for the duration specified in XMPlay settings. Is this the case or did I do something wrong?