SIDex plugin

Started by Keltic Danor,

Dhry

#40
All good man, thank you!

DRS

Edit: Would love to know if there's an easy way of taking the source code and building the dll myself. I'm not a dev/programmer AT ALL and have never done that before so if it's easy to do on Windows, could be fun to try.

Keltic Danor

#41
And here we go, more cleaning up among other things.

Quote from: DhryEdit: Would love to know if there's an easy way of taking the source code and building the dll myself. I'm not a dev/programmer AT ALL and have never done that before so if it's easy to do on Windows, could be fun to try.
I probably do it the complicated way to be honest but it works for me so I hesitate to rock my boat. I didn't keep notes during the setup but it is basically MSYS2 to install all the relevant MingW packages and I use Apache Netbeans as my IDE with the C/C++ plugin installed. It's honestly probably an excessive investment in time/space/headaches just to build the plugin but if you still want to give it a crack them more power to you!

Sebby75

"[0.8c] All STIL entries read instead of sub song specific due to missing records  "

have you reverted this back in 0.9?
I really preferred how it worked in 0.8c showing full STIL info for all of the subsongs on one page...   
version 0.9 seem to have reverted it to previous behaviour where it only shows STIL info for currently playing subsong...

Regards
Sebby75

Keltic Danor

#43
Quote from: Sebby75"[0.8c] All STIL entries read instead of sub song specific due to missing records  "

have you reverted this back in 0.9?
I really preferred how it worked in 0.8c showing full STIL info for all of the subsongs on one page...   
version 0.9 seem to have reverted it to previous behaviour where it only shows STIL info for currently playing subsong...

Regards
Sebby75
Ah... sorry unintended change, I was working on the STIL code to see if I could fix it missing out on data and must of forgot to switch it back afterwards.

Sebby75

Thanks..

Maybe it's just me.. I'm just used to STIL info (including all subtunes) being displayed on one page as it is in droidsound-e player for android.
It's never really too much text and sometimes you come across some interesting info which you could otherwise easily miss...

Regards
Sebby75

Keltic Danor

Yep, but you know how it is, people have their preferences. :)

Keltic Danor

#46
Hey all,

So we made it to v1.0! ;D, I have to say it certainly took a lot more time and effort than I could of ever anticipated but I'm really happy with the way things turned out. Probably the last update for a little while except for tweaks and bug fixes but as always feedback is welcome, otherwise it's time to do something less head scratching like a new skin or something. 8)

After over a week or two I got lucky with reference code for SIDid. Just a couple of things to be aware of.. firstly, instead of putting the SIDid settings in the plugin itself I have kept it using an external file (In the DOCUMENTS folder) as I like the idea of you being able to just download an updated cfg file from SIDid GitHub and secondly, the code to do it is actually from PSID64 and is 7+ years old so may need a few tweaks at some point. At least for now I have included a sidid.cfg file but I may remove it from the package in future since it isn't mine, perhaps I should ask Lasse Öörni about it.

For more fun I also spent 4 days writing a command line to convert the STIL.txt to a STIL.md5 which allowed me to get STIL records for sid tunes opened anywhere instead of having to be in the HVSC folder structure, it did make the STIL file a bit bigger but it was neat. I have not left it in for now though as my methods for searching and retrieving the records leave A LOT to be desired. Perhaps one day I'll add it back in and someone can help me write a more effective and less explosive way of reading it. Actually scratch that, the lookup is still inefficient as heck but it seems stable.

Oh just a note too, the STIL is still getting all entries instead of just the subsong one, I considered putting an option for it but eh... getting everything is easier.

Recent patch notes
v1.1
- Added md5 lookup alternative for files outside of HVSC directory
   Note: Requires stiltxt2md5 to be run in the DOCUMENTS/ folder first
v1.0
- Added fade-out option
- Added detect music player option
   Note: Requires sidid.cfg to be located in the DOCUMENTS/ folder
- Settings page has been rearranged slightly, it is a little glitchy, I'm okay with it

Downloads
xmp-sidex1.1.zip
xmp-sidex1.1source.zip

Support Site Entry
GitHub updated accordingly: https://github.com/KelticDanor/xmp-SIDex

Notes
- Tunes using the 8580 are a bit quieter than 6581 tunes, I don't really want to try to amplify audio so it'll just be like that at least for the moment.
- WinXP is not supported and probably won't ever be as besides not having a WinXP machine the MingW compiler doesn't appear to support WinXP anyway.

Known Issues
- Unable to open a SID from a url, local files only. I'm unsure how to open a SID from memory just yet but I'll try

Dr. Fiemost

Congrats for the 1.0 release  8)

Quote from: Keltic Danor- Tunes using the 8580 are a bit quieter than 6581 tunes, I don't really want to try to amplify audio so hopefully I've just missed a setting in libsidplayfp
Unfortunately when trying to push the 8580 volume louder it starts distorting badly. I suspect the 6581 output is too strong but can't say for sure.

Dhry

Got back from vacation yesterday and note that you have released 1.1. Excellent work! Installed it and am listening this morning.

- Almost no more audible clicks with the fade in. Have not tried the fade-out as yet. 99% of tracks have no click however honestly I don't think there's going to be one setting that fixes it for every single track so I'm super happy with the feature right now. Consider it perfect AFAIC.
- All songs so far sound perfect.
- I don't know why anyone would want to disable seeking, and I would never use that feature since I seek all the dang time - but I tried it and yep, it disables the seekbar as one would expect. ¯\_(ツ)_/¯

Everything right now is just 100% perfect with the plugin, you did an amazing job! I would say that for right now, just keep it periodically up to date with the latest libsidplayfp versions as they come out, every new thing added from here on out is fluff. Also, WinXP support? Good god man. Don't even bother.  :D

Quote from: Keltic DanorI probably do it the complicated way to be honest but it works for me so I hesitate to rock my boat. I didn't keep notes during the setup but it is basically MSYS2 to install all the relevant MingW packages and I use Apache Netbeans as my IDE with the C/C++ plugin installed. It's honestly probably an excessive investment in time/space/headaches just to build the plugin but if you still want to give it a crack them more power to you!



Cheers
DRS

Keltic Danor

#49
Quote from: Dr. FiemostUnfortunately when trying to push the 8580 volume louder it starts distorting badly. I suspect the 6581 output is too strong but can't say for sure.
Ah fair enough. I actually did more searching than you can poke a stick at for any references about the 8580 being quiet and outside of digitised stuff the digiboost is for I didn't find anything so I had just assumed it was a setting.


Quote from: Dhry- Almost no more audible clicks with the fade in. Have not tried the fade-out as yet. 99% of tracks have no click however honestly I don't think there's going to be one setting that fixes it for every single track so I'm super happy with the feature right now. Consider it perfect AFAIC.
- I don't know why anyone would want to disable seeking, and I would never use that feature since I seek all the dang time - but I tried it and yep, it disables the seekbar as one would expect. ¯\_(ツ)_/¯
Also, WinXP support? Good god man. Don't even bother.  :D
Yeah I'm quite chuffed with the fade-in, really glad Ian gave me a hand in polishing up!
I know it's odd but I disable seeking since I have a bad habit of accidentally clicking the progress bar when moving XMPlay about which normally isn't a big issue but it's not so fun when I click from 30seconds to 28 minutes on Gordian Tomb. ;D

Maybe known issues isn't quite the right heading for those now that I think of it, it's more of a FYI since I don't really have any intentions of messing with WinXP if I can help it. :P

Dhry

Just checking back in. Plugin v1.1 works great with everything I've thrown at it. Absolutely magic, no bugs, no additional requests.

Flawless work.

Dhry

Malade



hello all , i had a few hours spare today and ported  sidex to visual studio with latest libsidplay lib build into visual studio no lbgcc etc so the file size greatly reduced when built ( think it is around 160k compiled )  even more shaved off with petite pack, need some testers to make sure it works ok for everyone then i will release it as .1.2 , if not i will fix what is reported first can someone test this to make sure it works ok , windows compile with some extra features ( surround , voice muting etc.)
see screenshot. file attached

Malade

#52
hi Keltic Danor, i did try to reply to your pm but unfortunately there sempt to be a problem with sent messages , not sure if you received the message i sent.


https://www.mediafire.com/file/dy871e5nviaq22q/xmplaysid.zip

sourcecode xmp-sidex + libsidplayfp for visual studio 2017

unpack to C:\xmplaysid

launch C:\xmplaysid\xmp-sid\xmp-sid.sln and build.

edit : added latest build : xmp-sidex.dll libsidplay 2.2.2 ( fixed low volume 8580 )

edit : fixed surround ( now much deeper sounding )

file attached.

have fun. :)

Sebby75

Quote from: Maladeeed some testers to make sure it works ok for everyone then i will release it as .1.2 , if not i will fix what is reported first can someone test this to make sure it works ok , windows compile with some extra features ( surround , voice muting etc.)

very audible *pop* sound with plugin 1.2 at the start of the tune/subtune.. tried to play about with fade in but not really making much change..
switched back and forth between 1.1 and 1.2 couple of times testing various tunes..   not entirely sure if fade in works on 1.2 at all??

can't get my head around why channel selector has 3 sid chips there each with 3 voices? and not just 1 or two (for dual sid tunes).


will test some more in the evening..

Regards
Sebby75

Malade

Quote from: Sebby75
Quote from: Maladeeed some testers to make sure it works ok for everyone then i will release it as .1.2 , if not i will fix what is reported first can someone test this to make sure it works ok , windows compile with some extra features ( surround , voice muting etc.)

very audible *pop* sound with plugin 1.2 at the start of the tune/subtune.. tried to play about with fade in but not really making much change..
switched back and forth between 1.1 and 1.2 couple of times testing various tunes..   not entirely sure if fade in works on 1.2 at all??

can't get my head around why channel selector has 3 sid chips there each with 3 voices? and not just 1 or two (for dual sid tunes).


will test some more in the evening..

Regards
Sebby75
Hi ,
      i will look into the pop at the start thank's for letting me know ,  each sid chip has 3 voices voice0 voice1 and voice2 , 3 voices per chip is a total of 9 voice toggles for the 3 emulated sids.
 in hvsc there are 3 sid tunes as well as dual (2)sid tunes  3 sid chips are emulated to accommodate the 1 sid , 2 sid , and 3 sid tunes.

thank's for testing.

boobuts

I get a crash in v1.2 when changing HVSC path (no such issue with v1.1).


Regards

Keltic Danor

Quote from: Maladehi Keltic Danor, i did try to reply to your pm but unfortunately there sempt to be a problem with sent messages , not sure if you received the message i sent.

https://www.mediafire.com/file/dy871e5nviaq22q/xmplaysid.zip

sourcecode xmp-sidex + libsidplayfp for visual studio 2017
have fun. :)

Hey mate,

Yep, the messages worked just fine thanks for that, I've downloaded everything but haven't had the chance to take much of a look at it yet hopefully later this week and see how it goes. 8)

Malade

Quote from: boobutsI get a crash in v1.2 when changing HVSC path (no such issue with v1.1).


Regards

Hi,
    i looked into that it seems i hardcoded the path while i was testing a faster way of reading the stil info. , i will re-fix it for the next release.

  and thanks for letting me know.

Malade

Quote from: Keltic Danor
Quote from: Maladehi Keltic Danor, i did try to reply to your pm but unfortunately there sempt to be a problem with sent messages , not sure if you received the message i sent.

https://www.mediafire.com/file/dy871e5nviaq22q/xmplaysid.zip

sourcecode xmp-sidex + libsidplayfp for visual studio 2017
have fun. :)

Hey mate,

Yep, the messages worked just fine thanks for that, I've downloaded everything but haven't had the chance to take much of a look at it yet hopefully later this week and see how it goes. 8)

Hey Buddy,

Hows it going , regarding the source: have fun with it. :)
ps. Love the sound of the 64 , only have 2 real hardwares and i am not always able to get to the c64's its at the other place, cant beat it listening on real ( one has a sidfx with 8580 and 6581 chips ) hardware , the other has only one 6581 which tbh still sounds amazing.

back on topic: i think the next thing for the plugin is a dual sid option with a choice of chip type for each sid, if i get the time i will add that , c64 real hardware VERSUS this plugin with the latest libsidplayfp this plugin comes a close second. might add vic II display noise as well if i get the time, think the better way would be to sample my c64's and mix it in the output of the plugin, also take a look into fixing the strange octave bug in some of these latest libsidplayfp's im not sure but i do not think it was there in the earlier libsidplays , im going to take a look at it when i can.

Thanks for the great work , keep it up , all the best. :)

Dhry

Great to see ongoing development! No idea why this topic didn't autonotify me of the recent new replies though.
Will wait for the pop-fixed new build and check it out. Super excited for surround!

DRS