▲

[Keltic Danor]

Well done Kelt , good plugin , thanks for all the hard work. Keep going its good.

Well hello there Good to see you're still kickin', thought you got eaten by a grue!

When the "Fetch only current Sub-song STIL info" option is active, the general comment on all subsongs is not displayed.

Yes, it's a bit of a weird one I know, was something I noticed a while back and I think was why it I didn't do a subsong lookup at the time.
I'm not sure whether it is due to the STIL file structure or the look up itself since I'm not sure which way it is supposed to be. If you have a few examples I'll check it out and see what I can do, though it may be something I have to ask drfiemost about.

[guest]

SIDs containing subsongs with STIL file-global comment:
/MUSICIANS/B/Blues_Muz/Bombmania_II_preview_2.sid
/MUSICIANS/D/Daglish_Ben/Jack_the_Nipper_II.sid

[tails__]

I just noticed there are 2 new SID plugins for XMPlay available, thanks!

On a side note, I noticed that in plugin code you supply SID tags into UTF-8 text funtion for tag processing in XMPlay: https://github.com/KelticDanor/xmp-SIDevo/blob/66562a92ee6b5fc48aec60070b6c6d91cd56803d/xmp-sidevo/xmp-sidevo.cpp#L737 which causes garbled text for some tags which contain non-ascii characters. Is it possible to wrap these with MultiByteToWideChar() with 1250 code page, so the text is displayed properly on non-latin systems?

(Wish I could just fork and PR the code, but I miss windows environment to work on...)

[Sigma Seven]

Brilliant job with the plugin Keltic, XMPlay badly needs an up to date SID plugin for our listening pleasure.

Just as a side note, looking in the txt file that comes in the zip, at the bottom under install instructions it still says that the sidid.cfg should go in the HVSC\DOCS folder.

I'm assuming that's not the case and it must go in the plugin's folder? That's where I have it.

And I remember that the SIDex version had a rather nice equalizer in it, I was wondering if it would be possible to implement that in this one also? Would be very cool if we could play around with different settings and presets and whatnot.

[redneonglow]

I'm having an issue with SIDevo crashing XMPlay when trying to add WavPack files to the playlist.

"The "SIDevo 4.4" plugin crashed while attempting to scan the following file:

filename.wv

The crash will now be passed on to Windows."

and XMPlay exits with a "Runtime Error" message.

[Keltic Danor]

...I remember that the SIDex version had a rather nice equalizer in it, I was wondering if it would be possible to implement that in this one also?...

I don't have any plans to add that, I don't really get how it works to be honest so it probably wouldn't be a good idea. 

Is it possible to wrap these with MultiByteToWideChar() with 1250 code page, so the text is displayed properly on non-latin systems?

I'm not too familiar with the function but I can give it a try, I'm guessing it just converts the buffer given? You can test the below version but otherwise if you give me the code necessary to provide what you need I can put it in for you.

SIDs containing subsongs with STIL file-global comment:
/MUSICIANS/B/Blues_Muz/Bombmania_II_preview_2.sid
/MUSICIANS/D/Daglish_Ben/Jack_the_Nipper_II.sid

I've put in a fix of sorts to try out in the next version. You can test the below version with the change.

I'm having an issue with SIDevo crashing XMPlay when trying to add WavPack files to the playlist.

I was unable to reproduce this with any of the wavpack files I have, if you can provide the trouble one I can check it out? Ian gave me a sample, the below version should fix it?

This version also has the latest libsidplayfp-2.6.0. I'm not sure what the changes are but it seems a bit bigger so they've been up to something.

[guest]

Could you please share the file for guests?

[Keltic Danor]

Yep, uploaded here for now. Still in testing so not formally releasing it yet.

https://support.xmplay.com/temp/xmp-sidevo.4.5b.zip

v4.5b
- libsidplayfp library updated to 2.6.0
- Fixed issue with subsong STIL setting not getting sid comments
- Fixed tag display on non-latin systems
- Fixed random scanning of invalid files

[guest]

The plugin could also display info text from MUS files and words from the accompanying WDS files.
Also, for stereo tunes (MUS+STR), additional format information in the "General" info window.

[Keltic Danor]

The plugin could also display info text from MUS files and words from the accompanying WDS files.
Also, for stereo tunes (MUS+STR), additional format information in the "General" info window.

I can take a look at it, do you know where I can find the file format/specifications for WDS files? I'm not sure how to open them up. And what additional format information are you thinking of?

[guest]

MusiQt by drfiemost https://github.com/drfiemost/musiqt
displays comment from MUS file and lyrics from WDS in "Song info" dialog.

[guest]

Also, for stereo tunes (MUS+STR), additional format information in the "General" info window.

And what additional format information are you thinking of?

Format    C64 Stereo Sidplayer format (MUS+STR)
Sid Info  #2 - ...

[Keltic Danor]

Format    C64 Stereo Sidplayer format (MUS+STR)
Sid Info  #2 - ...

It doesn't look like libsidplayfp returns when it's using str or not so I can't identify it at the moment through there, I'll have a look at it in future.

-snip-

[guest]

\Dave_Collins\Pop_goes_the_World.mus
Plugin displays "(null)" in MUS Comments and only the first line of WDS Contents.

\BJ_Pools\Long_Cold_Winter.mus
XMPlay crashes while displaying Message window.

[Keltic Danor]

\Dave_Collins\Pop_goes_the_World.mus
Plugin displays "(null)" in MUS Comments and only the first line of WDS Contents.

\BJ_Pools\Long_Cold_Winter.mus
XMPlay crashes while displaying Message window.

I've revised how I'm loading and treating the WDS to match that other code and it solve the crashes, I've also ignored nulls in comments now.

https://support.xmplay.com/temp/xmp-sidevo.4.5d.zip

v4.5d
- libsidplayfp library updated to 2.6.0
- WDS files are now shown in the Message window
- Comments from MUS files are now showing in the Message window
- Fixed issue with subsong STIL setting not getting sid comments
- Fixed random scanning of invalid files causing crashes

[guest]

\DC_Star_and_Cpr\Noel_Time.mus
WDS Contents are not fully displayed.

[Keltic Danor]

\DC_Star_and_Cpr\Noel_Time.mus
WDS Contents are not fully displayed.

Looks like it does work but it has a million new lines in it for some reason, scroll down a bit?

[guest]

\DC_Star_and_Cpr\Noel_Time.mus
WDS Contents are not fully displayed.

Looks like it does work but it has a million new lines in it for some reason, scroll down a bit?

The last line should read: "FROM DC STAR" and it is "THE FIRES ARE BURNING ON THE HILL".

[Sigma Seven]

Would it be possible to fetch the subtune's NAME field from the STIL and have that inserted in the playlist window using a custom formatting string?

In the options on the 'titles' tab I'm using the following string, which displays " - Tune x" after the SID's title if the SID has a subtune:

%0%?9{ - Tune %9|}

After that we could have the actual NAME of the subtune from the STIL, if there's any.

So for example, these SIDs would look like this in the playlist:

Last Ninja 3 - Tune 3 - Intro Tune
Last Ninja 3 - Tune 4 - Mountains
Last Ninja 3 - Tune 9 - Game Over

Last Ninja 2 - Tune 1 - Central Park (loader)
Last Ninja 2 - Tune 8 - The Basement (in-game)
Last Ninja 2 - Tune 10 - The Office (in-game)

Turbo Outrun - Tune 1 - Intro
Turbo Outrun - Tune 2 - Title
Turbo Outrun - Tune 8 - Level 4

Ultima V-Warriors of Destiny - Tune 1 - Ultima Theme
Ultima V-Warriors of Destiny - Tune 4 - Engagement and Melee
Ultima V-Warriors of Destiny - Tune 7 - Fanfare for the Virtues

I'm guessing for this to work Ian would also need to add a new formatting string, for example 'subsong name' or something like that.

[Keltic Danor]

Not sure about the fancy sub song stuff but I'll have a look some time.

4.5 has been released now, the MUS WDS file conversion isn't perfect. I'm not sure why it doesn't show the full text for that file but I figure the best thing would be to just release it and update the repo and perhaps someone else might have an idea. There are other fixes in this one related to the crash fix which broke something else so even if you are using a previous 4.5 version I would suggest upgrading to the latest.

Change Log
v4.5
- libsidplayfp library updated to 2.6.0
- WDS files are now shown in the Message window
   - The reading of WDS/conversion from PETSCII is far from perfect, any code suggestions would be most welcome
- Comments from MUS files are now showing in the Message window
- Fixed issue with subsong STIL setting not getting sid comments
- Fixed random scanning of invalid files causing crashes

Download
https://support.xmplay.com/files_view.php?file_id=731 Download from XMPlay Support
https://github.com/KelticDanor/xmp-SIDevo Source on GitHub