Author Topic: XMPlay SID plugin  (Read 364602 times)

Fraggie

  • Posts: 714
Re: XMPlay SID plugin
« Reply #175 on: 7 Oct '06 - 15:31 »
BobbyG is right. This memory usage column in the Task Manager reffers to physical memory only. If you want to have real memory consumption of a program shown, you need to enable the virutal memory size column.

BTW, there is indeed memory leaking out in the STIL loading. After solving this bug, memory usage dropped by ~36 MB. I still need to think about the SLDB optimization though. (And it appears I lost 24c sources... Maybe I should get myself some kind of configuration managment tool for the future... ;D )

A bit offtopic, but what algorithm are you using? A MD5 hashtable or search tree? If I understand correctly a judy array (http://judy.sourceforge.net/) would be perfect for this kind of job. That would probably lower the memory need and more than double the speed if you are using a hashtable.
I'll look into it. :) Thanks for the tip!

Tero Niemi

  • Guest
Re: XMPlay SID plugin
« Reply #176 on: 7 Oct '06 - 16:35 »
Good thing and good riddance to that bug! My poor laptop has only 256Mb physical memory and I have to run Photoshop with XMPlay...

BobbyG is right. This memory usage column in the Task Manager reffers to physical memory only. If you want to have real memory consumption of a program shown, you need to enable the virutal memory size column.

I trust you guys. :) I don't understand Windows, I am just using it.

(Judy versus hashtable) would probably lower the memory need and more than double the speed.
Just remembered that this was another way around -- halve the memory usage and probably make faster -- but you got the idea. And I hate to distub with two minor oddities..

Oddity 1:
1) Go to SID plugin config screen, in "Song filter" set "Skip songs shorter than" to some big number (eg. 900).
2) Go to playlist and drag songs that are shorter than the limit to it.
-> Songlenghts are broken.

Oddity 2:
1) Add the following (small and ugly) SID to playlist: VARIOUS/M-R/Mermaid/Early_Tunes/Teknuh.sid
2) Go to SID plugin config screen, in "Fadeout" set "Duration" to 0ms.
3) Go to playlist and play the SID.
-> Song lenght is 0:09.
4) Go to SID plugin config screen, in "Fadeout" set "Duration" to 5000ms.
5) Go to playlist and play the SID.
-> Song lenght is now 0:14.

That's all. I won't find any more bugs, I promise!  :-X

Torkell

  • Posts: 1169
Re: XMPlay SID plugin
« Reply #177 on: 7 Oct '06 - 19:54 »
BobbyG...
Argh! Do I have to challenge you to a duel too?

Fraggie

  • Posts: 714
Re: XMPlay SID plugin
« Reply #178 on: 8 Oct '06 - 10:52 »
Oddity 1:
1) Go to SID plugin config screen, in "Song filter" set "Skip songs shorter than" to some big number (eg. 900).
2) Go to playlist and drag songs that are shorter than the limit to it.
-> Songlenghts are broken.
Setting to 900 means that the plugin should skip all subsongs shorter than 15 min, which should be pretty everything... So the plugin gets confused, how to play the file if it doesn't have any subsongs. To solve this bug, any .sid with all subsongs filtered out should be discarded.

Oddity 2:
1) Add the following (small and ugly) SID to playlist: VARIOUS/M-R/Mermaid/Early_Tunes/Teknuh.sid
2) Go to SID plugin config screen, in "Fadeout" set "Duration" to 0ms.
3) Go to playlist and play the SID.
-> Song lenght is 0:09.
4) Go to SID plugin config screen, in "Fadeout" set "Duration" to 5000ms.
5) Go to playlist and play the SID.
-> Song lenght is now 0:14.
This is not a bug. I bet you have "append fadeout" option enabled. It means that looped songs will be prolonged by the fadeout time.

That's all. I won't find any more bugs, I promise!  :-X
True. There just can't be any more bugs in this excellent software! ;)

Argh! Do I have to challenge you to a duel too?
I'll leave you devastated, mutilated and perforated!

Torkell

  • Posts: 1169
Re: XMPlay SID plugin
« Reply #179 on: 8 Oct '06 - 11:35 »
Argh! Do I have to challenge you to a duel too?
I'll leave you devastated, mutilated and perforated!
Perhaps you should switch to decaffinated?

Zarggg

  • Posts: 1242
Re: XMPlay SID plugin
« Reply #180 on: 9 Oct '06 - 23:39 »
Argh! Do I have to challenge you to a duel too?
I'll leave you devastated, mutilated and perforated!
Perhaps you should switch to decaffinated?
Just make sure he's not defenestrated. ;)

Fraggie

  • Posts: 714
Re: XMPlay SID plugin
« Reply #181 on: 12 Oct '06 - 19:28 »
Argh! Do I have to challenge you to a duel too?
I'll leave you devastated, mutilated and perforated!
Perhaps you should switch to decaffinated?
I am rubber, you are glue.

Argh! Do I have to challenge you to a duel too?
I'll leave you devastated, mutilated and perforated!
Perhaps you should switch to decaffinated?
Just make sure he's not defenestrated. ;)
How apropriate. You fight like a COW.
:)


Update 24d of the SID plugin has been released.

Changes to previous version:
  • fix for memory leak in STIL loading
  • memory optimization for SLDB loading
  • sids with all songs filtered out are now rejected
  • removed double displaying of start song, song numbers, song lengths if weren't changed (General Info window)
  • added displaying amount of memory needed for STIL and SLDB in About window

Please tell me if it makes any trouble.
@Tero Niemi: Please check if DELTA.SID still crashes with STIL enabled.

Remark 1: This update is critical. In total this revision reduces memory allocation by about 60,3 MB when loading STIL and SLDB. You may notice a small delay in loading XMPlay when using SLDB, however time for loading SIDs has not changed.

Remark 2: You now need MSVCR80.DLL and MSVCP80.DLL to load this plugin.
« Last Edit: 13 Oct '06 - 16:32 by Fraggie »

deus-ex

  • Posts: 277
Re: XMPlay SID plugin
« Reply #182 on: 13 Oct '06 - 17:41 »
Doesn't work for me. XMPlay closes down immediately with v0.24d. I have copied both Msvcp80.dll and Msvcr80.dll into the plugins dir along with Microsoft.VC80.CRT.manifest. Also tried placing the dlls into XMPlays main directory. No go.

Fraggie

  • Posts: 714
Re: XMPlay SID plugin
« Reply #183 on: 13 Oct '06 - 18:45 »
Well that's just great...
Is it closing on XMPlay start? Or when you try to play a SID?
I have also observed that it crashes on playing when SLDB is disabled...

Back to the drawing board, I guess..
« Last Edit: 13 Oct '06 - 18:47 by Fraggie »

Fraggie

  • Posts: 714
Re: XMPlay SID plugin
« Reply #184 on: 13 Oct '06 - 19:01 »
Please re-try.

If it still doesn't work, try installing the VC8 runtime DLL's with this:

http://www.microsoft.com/downloads/details.aspx?FamilyId=32BC1BEE-A3F9-4C13-9C99-220B62A191EE&displaylang=en
« Last Edit: 13 Oct '06 - 19:13 by Fraggie »

Tero Niemi

  • Guest
Re: XMPlay SID plugin
« Reply #185 on: 13 Oct '06 - 23:31 »
Wonderful! Memory use is dropped down to minimum!

But the STIL still crashes (pun not intended) when switching from subsong 3/13 to 4/13 on "Delta.sid".
The crash can be avoided by unchecking "Show: [ ] file comments".

I dumped my STIL file (and Delta.sid) into:
http://cc.joensuu.fi/~tniemi/STIL.zip
if you want to run a diff.

I made a fresh install into new dir, and the system was:
Platform:   Windows XP Home Edition
Platform version:   5.1
Platform build number:   2600
Platform info:   Service Pack 1
Processor:   Clone of Intel Pentium (586)

Cheers, very good job!

Tero

tniemi

  • Posts: 43
Re: XMPlay SID plugin
« Reply #186 on: 14 Oct '06 - 02:56 »
(I noted it's better to create username for me as I always seem to hang around here...)

The /Gray_Matt/Last_Ninja_2.sid also crashes when jumping from subsong 11/13 to 12/13. Unchecking both "[ ] file comments" and "[ ] subsong comments" helps though...

And these are not bugs, but more like possible additional fixes:

You may want to change "Copyright" to "Released" in Message screen.
Quote from: hv_sids.txt
[3-3]: SID Credits
==================

Please note that of HVSC 5.2, the COPYRIGHT keyword has been replaced with
RELEASED.  This is mainly for legal reasons, as many of the games which were
published in the 1980s are not the copyright of the original software companies
anymore, but reside with the programmers.  In addition, in a lot of cases,
the composer has retained his original copyright for the piece or asked a
publisher (such as C64Audio) to do that for them.  Also, it should more
accurately state when demo tunes were either composed or released into
the C64 scene, as many of those demo composers retain the copyright of
the tunes themselves.

And due to HVSC rearrangements, the following SIDs in top 100 have changed place/name:
Quote from: Creators.txt

 38. /Clarke_Peter/Ocean_Loader_v3_0.sid
       => /Clarke_Peter/Ocean_Loader_3.sid

 77. /FAME/FAME_1.sid      
       => /FAME/Hendriks_Michael/FAME_1.sid

 98. /Galway_Martin/Ocean_Loader_v2.sid   
       => /Galway_Martin/Ocean_Loader_2.sid

(This should be fixed also in HVSC. I am sending a request for that...)

So far the current edition of the SID plugin has worked a way better. I really like what you have done to the General information screen. More accurate and informative now.

Tero
« Last Edit: 14 Oct '06 - 03:18 by tniemi »

deus-ex

  • Posts: 277
Re: XMPlay SID plugin
« Reply #187 on: 14 Oct '06 - 05:43 »
Updated Plugin works. Checked both with STIL en- and disabled. :)

Rah'Dick

  • XMPlay Support
  • Posts: 963
Re: XMPlay SID plugin
« Reply #188 on: 16 Oct '06 - 12:04 »
Does the silence on this thread mean that it's safe to put the update on the Support Site? :)

Fraggie

  • Posts: 714
Re: XMPlay SID plugin
« Reply #189 on: 16 Oct '06 - 18:41 »
Well, it's operational I suppose... :)

(However I'm fixing a bigger update of the plugin at the moment. I guess it's going to be ready for next week.)

tniemi

  • Posts: 43
Re: XMPlay SID plugin
« Reply #190 on: 17 Oct '06 - 05:36 »
I think it has reached the Google Beta level. ;D

After massive test use of "beta 24d" the only problems I have encountered are the STIL troubles (as described before) and a bit high (60-70%) processor use in stereo mode (only 20% while in mono). Neither of these prevent playing.

piovrauz

  • Posts: 974
Re: XMPlay SID plugin
« Reply #191 on: 17 Oct '06 - 08:09 »
mmm.... I can't get the updated plugin to work, it siply closes XMPlay. ???
I have tried copying the requred dll in system32, or in the plugin directory, and installed the vb8 runtime, but I can't play sids... Why? What am I missing?
Back to the days of MSVCR71 I had to copy them in system32, and all worked like a charm, but now I'm out of luck, it seems. Pretty please help me!  :'(

Fraggie

  • Posts: 714
Re: XMPlay SID plugin
« Reply #192 on: 17 Oct '06 - 19:11 »
Make sure you're using the 13-Oct version.

piovrauz

  • Posts: 974
Re: XMPlay SID plugin
« Reply #193 on: 18 Oct '06 - 08:05 »
I can't find this 13 Oct(ober?) version, I have beta 24d downloaded from www.pieknyman.tk...

Fraggie

  • Posts: 714
Re: XMPlay SID plugin
« Reply #194 on: 18 Oct '06 - 12:09 »
Your problem seems to be similar to the issue that Deus-ex had, so please re-download the plugin if the date of your XMP-SID.DLL is not 13-0ctober-2006. I guess that if the problem was because of missing CRT DLL's you would get an error message.

piovrauz

  • Posts: 974
Re: XMPlay SID plugin
« Reply #195 on: 18 Oct '06 - 12:25 »
As I stated before, I have downloaded the plugin from www.pieknyman.tk, so it's 24d. I don't know about the date, since the plugin doesn't even show in plugin windows of xmplay...  In the file properties I read (translated): created 05/10/2006, last modify 13/10/2006, last access 18/10/2006. Maybe it's this? for now, I'll go with the old one...

Kekule

  • Guest
Re: XMPlay SID plugin
« Reply #196 on: 29 Oct '06 - 14:14 »
Weird... The new SID plugin works well with several tunes in the HVSC, but fails with some new ones: try for example to play all the new tunes from http://www.c64.sk/index.php?content=article.php&articleid=115&id=4075&PHPSESSID=bb08333f04f036be709925c25e5b547b

Fraggie

  • Posts: 714
Re: XMPlay SID plugin
« Reply #197 on: 30 Oct '06 - 09:55 »
Oops...  ;D
In the meantime you can modify xmplay.ini (SID section):

Code: [Select]
RSIDSLDB=0

Tri-City-Maniac

  • Guest
Re: XMPlay SID plugin
« Reply #198 on: 4 Nov '06 - 18:38 »
Maybe a silly question, but i can't jump between the subsongs. The SID-Plugin is installed correctly and i can load sid's ... for example there is a 1/19 from To Be On Top from Chris Hülsbeck ... but i can't go to 2/19 and so on ... what buttons should i use? Help would be cool, thanks ...

Tsorovan

  • Posts: 1247
Re: XMPlay SID plugin
« Reply #199 on: 4 Nov '06 - 19:03 »
Right-click the prev/next track buttons. You can also bind your own hotkeys in Options and Stuff.