Old:Winamp Visualisations in XMPlay (0.9.11) (plus album art with auto download)

Started by Barna,

Barna

sanb, I found time to look into your enquiry and replied to both the PM and the mail :-)

And you're right about the damaged ZIP...  o_O... damn you FTP! Thanks for reporting!

amit

Quote from: Barna
Quote from: amitI am playing network files as streams. it takes a few seconds until xmplay reads the files' tags - more than the time amazon cover downloader needs to return a negative response. Can you allow ACD to try multiple times to download the cover or alternatively allow to set a delay before its first try to download a cover?
It should be more intelligent now.
The plugin already retried before when the radio station/cue title changed. Now it does on any kind of song title tag change. Hope it works for you.

Here's the new version (not any change on the Winamp plugin wrapping, only cover art, as described above):
Download: http://www.nukular.ch/winamp_svp_0.7.zip

It is working better , thanks.

I have just noticed xmplay take about 30-40 percent of cpu power while showing album cover , even at a very small panel size. I tried reverting back to previous version but it's the same. Is this the situation for others also?

Barna

hmm, constant high CPU usage really shouldn't happen...
There's only much going on during loading / switching / fading of covers.

Can you see if the high CPU is still there when no song is playing and the play list is empty (shows No Album Cover) or if there is still high CPU when some/all of the album art features like fading/auto downloading/cover cycling are disabled. Also is the CPU usage still high when showing of album art is disabled?
Well high CPU could happen because of a running Winamp plugin of course, too, but I guess you're not running one currently.

amit

I checked again - the problem was not your plugin. The Vertical sync in the options was ticked so all visualizations hogged the cpu.

amit

one more request - can you add another 'alignment' option: to stretch the image to fit the viewable area without leftovers.

Ian @ un4seen

Quote from: BarnaJust before I released 0.6 clicking on the bar in Tripex3 was disabled/not handled. Then I tried if XMPlay accepts the scrolling to a given timestamp (IPC_JUMPTOTIME) and it really did work... Well, at least I seem to remember that it worked then.
Then after I read your posting I tried again, and it didn't work anymore, but it didn't crash XMPlay here, it just restarted the song at 0:00 when being clicked anywhere.

Ah yes, I think I see a bug in the IPC_JUMPTOTIME processing, which would result in seeking to 0:00 instead. Here's an update to try...

   www.un4seen.com/stuff/xmplay.exe

Quote from: BarnaI don't know if Ian wants to add another special input QueryInt for disabling all info bubbles

OK, the update above also adds an "xmplay:nobubble" QueryInt option for that. As with the "minupdate" option, it is automatically reset each time a new plugin is loaded.

Again, I've not tested it, so please report any unpleasant side-effects :)

Barna

Yep, thanks a lot Ian, both features work like a charm.

Quote from: amitone more request - can you add another 'alignment' option: to stretch the image to fit the viewable area without leftovers.
Sounds like a nice addition and as it was only 3 new lines of code there wasn't much to think about it :-)

So here's 0.8 already with that and which disables the info bubbles while a winamp plugin is running (it doesn't affect anything if the plugin is only used for covers):

Download: http://www.nukular.ch/winamp_svp_0.8.zip

piovrauz

Here my tests results:

1. Disable bubble new "mod": all works fine here, tested with tripex3, milkdrop2, geiss2. Now there is no "interference" with the actual plugin graphics. Great! Thanks Barna, thanks Ian. :)

2. tripex3 position bar works properly now. Again, thanks Barna, thanks Ian. ;)

Very nice. ;D

amit

Barna , thanks for the update.

one more thing: I can do fine without downloading images but it would be better if images were downloaded  and looked for in a single customized directory instead of the file's own directory.can make this optional?

Lesmo16

Quote from: Barna
Quote from: Lesmo16It would be fantastic, if your plugin would cycle through all valid images in the playing folder. The cycle time should be user definable.
It's available now in 0.7. It is set to 10 seconds per default and can be changed by closing the visualisation (after enabling the cycling) and changing albumart_cycleseconds in vis.ini in the XMPlay directory. Hope thats fine.
I also added some fancy cover art fading. It looks nice here, but may be annoying on slower computers or when displaying album art in a bigger window/full screen. So the fading can be disabled easily in the usual middle mouse menu.
Thank you Barna - great plugin!!!  :D

amit

It is possible somehow to make the winamp viz window to stay on top?

dardevilbrequin

 :D

Woaw thanks a lot for that plugin !!
That was the only missing feature that was making me staying with winamp.

Now I can see all my album art , collected during years !!!

Really great job

Chocobito

I never probe this plugin waiting por the final version but today I dont wait anymore and... :D Wow, really stable and work flawless, excellent work Barna  ;)

Barna

Quote from: amitone more thing: I can do fine without downloading images but it would be better if images were downloaded  and looked for in a single customized directory instead of the file's own directory.can make this optional?
0.9 now asks if covers should be stored into the songs directory or a default one when enabling to save covers on disk. Hope it works as imagined :-)

Quote from: amitIt is possible somehow to make the winamp viz window to stay on top?
It does take the setting from the XMPlay window, so you need to enable always on top for XMPlay in its options (Options -> Miscellaneous -> On top). If you want a custom option for the visualisation unrelated to XMPlay's status, uhhh, maybe I can add that for the next version.

Everyone else, thanks for the acknowledgment. Looks like we're getting to 1.0 soon, probably will rename the thing then too...

Here's 0.9 download: http://www.nukular.ch/winamp_svp_0.9.zip

amit

Does the amazon downloader consumes 99% of cpu cycles while working? (it was similar in previous versions)
While it consumes all cpu power network files cannot load. Is it possible to lower the priority of ACD when calling for it from plugin? maybe it will help.

(thanks for the single folder option :) )

Barna

Hmm... I'm unsure if that is caused by ACD or because of the regular cover loading procedure. The plugin reopens the audio (mp3) file as it looks for covers embedded in the ID3 tag again just after XMPlay opened the file for playing. Are you sure the experienced lag doesn't happen when ACD is disabled?
Well I'll try to lower the thread priority of the cover loading part and the priority of the launched ACD process for the next version. Maybe things get better. If not, probably the only thing that could solve that would be a short delay in cover loading.

amit

The process that takes 99% is ACD .When ACD is disabled this problem does not exist. Does ACD takes so many resources at your system also?

Is it possible differentiate in xmplay between opening a file and actually playing it? Maybe it would be possible to start ACD only when actual playback of a file starts and not when it only tries to read a file.

Barna

Well, try this release... It launches the ACD process with IDLE priority.
http://www.nukular.ch/winamp_svp_0.9.1.zip

The covers should only be read on an the actual playing of the song. The plugin checks the current playing song filename and tags (as filename doesn't change on radio streams for instance) three times per second. So only after XMPlay actually started the song covers are loaded / ACD is started.

Mmh, maybe I'll look into getting an alternative to ACD in the near future... I'm not sure if ACD, as an old unsupported VB6, to be replaced with .NET, application is the way to go. Talking with the Amazon webservice to query for covers doesn't seem to be that complicated.

amit

The problem with the network files is solved but now the "save to one default folder" option is not working (or am I doing something wrong?) .It isn't saving the covers to selected folder.  Is it working for you?

Barna

uhm, how are you listening to your network files? Are you accessing them via network file system or are you listening through a http:// webserver? If it's through http cover saving does and should not work, as usually http streams are radio and who would want to save all covers from a radio stream anyway. But I guess it needs another option in that case.

amit

Most of my music is located on a local http server and the address is http://localhost:8045/....  I wasn't aware it was intentionally not downloading but it makes sense to avoid downloading covers for live internet radio.

BassFan

Feine sache das Plugin läuft auch unter BassVis mit einschränkung
gruss BassFan

piovrauz

mmm, I think there is another litlle thingie I can ask for: the ability to display cover(s) when playing files frome an archive (7z,zip,...); I mean, if the cover(s) is/are in the archive file. what's about that?

Barna

I'll try to use the XMplay archive features which seem to be available to my vis plugin for that. If that doesn't work out, there are rather slim chances for that. I just checked the programming interface and it at least looks like enough features are available to implement that, but maybe it's somehow limited to music only or something else I didn't consider. I'll try tonight.

On another note my last big change since last release is an integration of the auto cover downloading feature. This works out pretty well. It's now even able to download multiple covers and let the user chose which one to save to disk.

As it's nearing 1.0 anyway I'm looking into a release with a new name, but I have yet to find one :-) Anyone has an idea? As it is both cover display and winamp wrapping it will probably end up with something weird. Splitting it into two plugins doesn't really make sense as long as Winamp needs it's own vis-window anyway (my integration into XMPlay of these failed horribly).

piovrauz

Pretty good news then :)

Another thing I noticed is that if the title contains utf8 stuff (japanes characters, for example) it's show on milkdrop as a bunch of ?. Is it possible to fix this or it's an issue with milkdrop itself?

btw, thanks for the plugin again, I love it ;)